Page MenuHomePhabricator
Create Task
Maniphest T290035

Edits to the page sent as a message before a mass message job finishes causes content sent to also change
Open, MediumPublicBUG REPORT
Actions

Description

I sent a MassMessage using Version#1 of a translated page, then after sending I waited a few seconds, then edited that page and marked it for translation (intended to reuse it in future months), but MassMessage delivered Version1 to some destinations, and Version2 to other destinations. This resulted in some confusion.

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The page message content comes from Version2 after the edit to the page being sent.

What should have happened instead?:

  • The content sent in the mass message should not change from the one in Version1

Related Objects
Search...

Event Timeline

Quiddity created this task.Aug 30 2021, 7:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2021, 7:40 PM
Nikerabbit subscribed.Jan 26 2022, 9:27 AM

The content is fetched dynamically at the time of delivery. The content is not stored at the time of initiating the delivery, as the content could be very large and it is not reasonable to store that in the job queue.

Nikerabbit moved this task from Backlog to Message building on the MassMessage board.Jan 26 2022, 9:31 AM
Dreamy_Jazz triaged this task as Medium priority.Dec 18 2022, 10:12 PM
Dreamy_Jazz subscribed.

The method to post could reference a revision ID instead of the page. This is better as when "previewing" the page using Special:MassMessage the content shown there should the content sent to everyone. This means that using the revision ID instead of just the page title would allow the "preview" to actually be what is sent out to everyone. This also means that associated logs can store the revision ID of the page being sent as this is currently not stored (task for that is T323146).

Dreamy_Jazz mentioned this in T228218: Special:MassMessage shows "send" button and copyright notice even when message can't be sent.Dec 18 2022, 10:45 PM
Dreamy_Jazz added a subtask: T228218: Special:MassMessage shows "send" button and copyright notice even when message can't be sent.
Dreamy_Jazz renamed this task from MassMessage does not send a static revision to a large target list to Edits to the page sent as a message before a mass message job finishes causes content sent to also change.Dec 18 2022, 10:48 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz added a comment.Dec 18 2022, 10:54 PM

This becomes a problem if the page to be sent as a message changes in any way. The risk of this happening increases if:

  • Any of the MassMessage jobs associated with the sent mass message are delayed
  • The page being sent as a message is intended to be left as is, but vandalism is a possibility
  • The page being sent as a message is changed after submission for the next message to be sent
Dreamy_Jazz added a parent task: T323146: MassMessage logs should use permalink for the target list.Dec 18 2022, 10:55 PM
Dreamy_Jazz mentioned this in T323146: MassMessage logs should use permalink for the target list.
Nikerabbit added a comment.Dec 21 2022, 1:06 PM

It's a never-ending goal ... time-dependent magic words, templates, translation may be added any time. It's not feasible to lock everything down at the time of sending, other than generating the content at that time, which can be too big for the job queue.

In addition T323146: MassMessage logs should use permalink for the target list should not be a parent task, since target list is a different thing from the content being send.

Dreamy_Jazz removed a parent task: T323146: MassMessage logs should use permalink for the target list.Dec 21 2022, 1:07 PM
Aklapper closed subtask T228218: Special:MassMessage shows "send" button and copyright notice even when message can't be sent as Resolved.Jan 4 2026, 6:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits