Page MenuHomePhabricator
Create Task
Maniphest T290040

Add Image: Rename message keys that are not specific to add link
Closed, ResolvedPublic
Actions

Description

Once T289211: Add Image: Generalize Add Link ResourceLoader modules is done, there will be message keys that are used in generic structured task modules that are prefixed growthexperiments-addlink. These should be renamed for consistency and their corresponding qqqs should be updated as well.

Here are the list of keys that should be re-named & their updated names:

growthexperiments-addlink-editmode-confirmation-dialog-titlegrowthexperiments-structuredtask-editmode-confirmation-dialog-title
growthexperiments-addlink-editmode-confirmation-dialog-messagegrowthexperiments-structuredtask-editmode-confirmation-dialog-message
growthexperiments-addlink-editmode-confirmation-dialog-action-confirmgrowthexperiments-structuredtask-editmode-confirmation-dialog-action-confirm
growthexperiments-addlink-editmode-confirmation-dialog-action-cancelgrowthexperiments-structuredtask-editmode-confirmation-dialog-action-cancel
growthexperiments-addlink-editmode-selection-machine-suggestionsgrowthexperiments-structuredtask-editmode-selection-machine-suggestions
growthexperiments-addlink-editmode-selection-visualgrowthexperiments-structuredtask-editmode-selection-visual
growthexperiments-addlink-editmode-selection-labelgrowthexperiments-structuredtask-editmode-selection-label
growthexperiments-addlink-ve-machine-suggestions-mode-submit-buttongrowthexperiments-structuredtask-ve-machine-suggestions-mode-submit-button
growthexperiments-addlink-no-suggestions-found-dialog-messagegrowthexperiments-structuredtask-no-suggestions-found-dialog-message
growthexperiments-addlink-no-suggestions-found-dialog-buttongrowthexperiments-structuredtask-no-suggestions-found-dialog-button
growthexperiments-addlink-ve-machine-suggestions-mode-titlegrowthexperiments-structuredtask-ve-machine-suggestions-mode-title

See: https://translatewiki.net/wiki/FAQ#Is_it_possible_to_rename_message_keys?

Details

SubjectRepoBranchLines +/-
Structured Tasks: Rename message keys used in edit mode toggle & machine suggestions modemediawiki/extensions/GrowthExperimentsmaster+46 -50
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mewoph created this task.Aug 30 2021, 10:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2021, 10:16 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 30 2021, 10:16 PM
• mewoph mentioned this in T289211: Add Image: Generalize Add Link ResourceLoader modules.Aug 30 2021, 10:24 PM
MBinder_WMF added a project: Image-Suggestions.Aug 31 2021, 12:51 AM
kostajh triaged this task as Medium priority.Sep 2 2021, 1:17 PM
• mewoph updated the task description. (Show Details)Sep 8 2021, 5:01 PM
• mewoph updated the task description. (Show Details)Sep 8 2021, 8:59 PM
gerritbot added a comment.Sep 8 2021, 9:54 PM

Change 719637 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured Tasks: Rename message keys used in edit mode toggle & machine suggestions mode

https://gerrit.wikimedia.org/r/719637

gerritbot added a project: Patch-For-Review.Sep 8 2021, 9:54 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 8 2021, 10:04 PM

Also created {{doc-growthexperiments-structuredtask}} to link to generic structured task project page instead of task type specific one (https://translatewiki.net/wiki/Template:Doc-growthexperiments-structuredtask) & emailed translatewiki to inform them of the renaming per suggestion in the FAQ

gerritbot added a comment.Sep 10 2021, 7:20 PM

Change 719637 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured Tasks: Rename message keys used in edit mode toggle & machine suggestions mode

https://gerrit.wikimedia.org/r/719637

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 10 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2021, 8:10 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 13 2021, 9:58 AM
kostajh subscribed.
In T290040#7340829, @mewoph wrote:

Also created {{doc-growthexperiments-structuredtask}} to link to generic structured task project page instead of task type specific one (https://translatewiki.net/wiki/Template:Doc-growthexperiments-structuredtask) & emailed translatewiki to inform them of the renaming per suggestion in the FAQ

Thanks @mewoph!

Etonkovidova closed this task as Resolved.Sep 15 2021, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits