Page MenuHomePhabricator

Add Image: Rename message keys that are not specific to add link
Closed, ResolvedPublic

Description

Once T289211: Add Image: Generalize Add Link ResourceLoader modules is done, there will be message keys that are used in generic structured task modules that are prefixed growthexperiments-addlink. These should be renamed for consistency and their corresponding qqqs should be updated as well.

Here are the list of keys that should be re-named & their updated names:

growthexperiments-addlink-editmode-confirmation-dialog-titlegrowthexperiments-structuredtask-editmode-confirmation-dialog-title
growthexperiments-addlink-editmode-confirmation-dialog-messagegrowthexperiments-structuredtask-editmode-confirmation-dialog-message
growthexperiments-addlink-editmode-confirmation-dialog-action-confirmgrowthexperiments-structuredtask-editmode-confirmation-dialog-action-confirm
growthexperiments-addlink-editmode-confirmation-dialog-action-cancelgrowthexperiments-structuredtask-editmode-confirmation-dialog-action-cancel
growthexperiments-addlink-editmode-selection-machine-suggestionsgrowthexperiments-structuredtask-editmode-selection-machine-suggestions
growthexperiments-addlink-editmode-selection-visualgrowthexperiments-structuredtask-editmode-selection-visual
growthexperiments-addlink-editmode-selection-labelgrowthexperiments-structuredtask-editmode-selection-label
growthexperiments-addlink-ve-machine-suggestions-mode-submit-buttongrowthexperiments-structuredtask-ve-machine-suggestions-mode-submit-button
growthexperiments-addlink-no-suggestions-found-dialog-messagegrowthexperiments-structuredtask-no-suggestions-found-dialog-message
growthexperiments-addlink-no-suggestions-found-dialog-buttongrowthexperiments-structuredtask-no-suggestions-found-dialog-button
growthexperiments-addlink-ve-machine-suggestions-mode-titlegrowthexperiments-structuredtask-ve-machine-suggestions-mode-title

See: https://translatewiki.net/wiki/FAQ#Is_it_possible_to_rename_message_keys?

Event Timeline

kostajh triaged this task as Medium priority.Sep 2 2021, 1:17 PM

Change 719637 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured Tasks: Rename message keys used in edit mode toggle & machine suggestions mode

https://gerrit.wikimedia.org/r/719637

Also created {{doc-growthexperiments-structuredtask}} to link to generic structured task project page instead of task type specific one (https://translatewiki.net/wiki/Template:Doc-growthexperiments-structuredtask) & emailed translatewiki to inform them of the renaming per suggestion in the FAQ

Change 719637 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured Tasks: Rename message keys used in edit mode toggle & machine suggestions mode

https://gerrit.wikimedia.org/r/719637

kostajh subscribed.

Also created {{doc-growthexperiments-structuredtask}} to link to generic structured task project page instead of task type specific one (https://translatewiki.net/wiki/Template:Doc-growthexperiments-structuredtask) & emailed translatewiki to inform them of the renaming per suggestion in the FAQ

Thanks @mewoph!