Page MenuHomePhabricator

Add client side validation on user input
Closed, ResolvedPublic13 Estimated Story Points

Description

Parent task for T287951 and T289058's error/warning states

Acceptance criteria:

From T289058: Create Text area component - Additional States

  • Wikit component accepts Error prop with the 'error' type and displays an error message (as specified in the Figma file)
  • Wikit component accepts Error prop with the 'warning' type and displays a warning message (as specified in the Figma file)

From T287951: error handling for Item ID input

  • Input is syntactically validated on submit
    • We consider a line as syntactically incorrect if it is not "Q+natural numbers"
    • We only accept one ID per line, not several IDs per line
  • Warning is shown when submitting an empty list of Item IDs

Event Timeline

karapayneWMDE set the point value for this task to 13.
ItamarWMDE renamed this task from client side error handling to Add client side validation on user input.Sep 1 2021, 9:23 AM
ItamarWMDE updated the task description. (Show Details)
Plan of Action (Task Breakdown 2021-09-01):

WiKit Land: Add error and warning states to WiKit Component (T289058) - Itamar will create subtasks

  1. Add states to TextArea in WiKit
  2. Make WiKit pre-release

Super Mismatch Brothers Castle: Enable users to send IDs (T287952) - Silvan will create subtasks

  1. Implement WiKit States in Mismatch Finder
    • Implement warning on empty field when pressing the submit button
    • Implement error on malformed QIDs when pressing the submit button

Everything is fine with this one.
@Lydia_Pintscher would you agree? Therefore I can resolve it.