Page MenuHomePhabricator

[regression-wmf.20] Recent changes filters disappear from the menu
Open, Needs TriagePublicBUG REPORT

Description

The report of the bug came from Wikipedia:Village pump (technical)#Filters_disappear from_Recent Changes

  1. On RC page (enwiki) with default filters results displayed (https://en.wikipedia.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&limit=50&days=30&urlversion=2), select one of the User intent prediction filters (e.g. Very likely bad faith etc). The display results will be updated. (https://en.wikipedia.org/wiki/Special:RecentChanges?goodfaith=verylikelybad&limit=50&days=30&urlversion=2 )
  2. Remove default filters by clicking on 'x' - only Very likely bad faith should be left. (https://en.wikipedia.org/wiki/Special:RecentChanges?goodfaith=verylikelybad&limit=50&days=30&urlversion=2)
  3. Reload the page. (https://en.wikipedia.org/wiki/Special:RecentChanges?goodfaith=verylikelybad&limit=50&days=30&urlversion=2)
  4. Wait till the message "View new changes since..." will appear.
  5. Click to remove the filter Very likely bad faith - the filter selection area is empty now. https://en.wikipedia.org/wiki/Special:RecentChanges?limit=50&days=30&urlversion=2
  6. Reload the page manually. The resulting url is different from the one in Step 1 - (https://en.wikipedia.org/wiki/Special:RecentChanges?limit=50&days=30&urlversion=2)
  7. Click to see the drop-down filter menu - the whole section - the Contribution quality predictions - will be missing.
Correct view - both filter sections are present; the vertical scroll down marker is at the topContribution quality prediction filters are missing
Screen Shot 2021-08-31 at 4.58.28 PM.png (1×1 px, 346 KB)
Screen Shot 2021-08-31 at 4.58.00 PM.png (1×1 px, 322 KB)

More screenshots to illustrate that the either of ORES filters sections (or both) could be missing:

  • User intent predictions filters are missing

Screen Shot 2021-09-01 at 12.00.16 PM.png (1×2 px, 391 KB)

  • both groups of filters are missing - Contribution quality predictions filters and User intent predictions filters

Screen Shot 2021-08-31 at 5.48.28 PM.png (1×1 px, 293 KB)

Notes:

  • seems to be happening on high-traffic wikis
  • the issue is specific to Contribution quality prediction filters and the User intent prediction filters
  • manual reloading action to trigger the issue could be emulated by returning to the RC page from other pages
  • after the section with filters disappears, the page requires several reloads to bring them back

Event Timeline

Etonkovidova renamed this task from [regression-wmf.20] Recent changes filters dissapear after from the menu after to [regression-wmf.20] Recent changes filters dissapear from the menu .Sep 1 2021, 12:23 AM
Etonkovidova renamed this task from [regression-wmf.20] Recent changes filters dissapear from the menu to [regression-wmf.20] Recent changes filters disappear from the menu .Sep 1 2021, 3:02 AM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh added a subscriber: DMburugu.

We need to discuss how to prioritize this among other ongoing work. cc @MMiller_WMF @DMburugu.

I'm trying to determine if this belongs in Tech News, and if so, how to describe it.

  1. Please confirm that this is a bug which [is/might be] affecting many editors across multiple wikis, and is somewhat likely to be encountered by any given wiki - to justify the inclusion. I.e. I cannot tell whether this is a rarely-encountered edge-case that not many editors will need to learn about, or if it is something that many editors might be seeing and simply not reporting.
  2. Please confirm if this description is accurate, and/or offer a clarified wording that can be used.

There is a problem with showing some of the edit review filters in some circumstances. Developers are working on fixing it.

This appears to be low-impact (only 1 user-report, of an edge-case scenario), so I will leave it out of Tech News.

I have been impacted by this bug several times when patrolling RC and wanted to figure out why it was happening, so I did a test which involved running RC side-by-side on two different browsers (Chrome and Opera GX) on separate accounts, with RedWarn uninstalled and installed, but I couldn't replicate the bug. Nevertheless I still have suspicions that the bug could be caused by the browser I'm using (Opera GX, which is also the browser that the original reporter on en.wp (@Blaze_The_Wolf) is using) and/or my and/or their user scripts.

This appears to be happening with my 8th generation iPad for school as well, so it looks that the bug is not specific to any web browser.

@PorkchopGMX, have you tried to browse recent changes while adding &safemode=1 to the URL? It would kill all scripts, gadgets or personal JS/CSS if any. If you still experience it while in safemode, it will help us identifying the issue.

@Trizek-WMF just got done doing some testing,

  • I was able to replicate the bug on my main account, safemode on. Took approximately 2 minutes.
  • I was unable to reproduce the bug on an alt account with default preferences and safemode on. (for reference, the account is "PorkchopGMX test2")

I used the same browser (Opera GX) and same computer (HP Pavilion Gaming Desktop TG01-2176z Bundle PC running Windows 11) for both tests.

I've been doign some more vandalism stuff recently and I have noticed it is also definitely not browser- or computer-specific as I have had it happen both on my home desktop running Windows 10 and with Wikipedia on Opera GX and my school chromebook running Chrome OS (cause you can't run anything else on a Chromebook) with Wikipedia on Google Chrome. Haven't tested it on my alt yet to see if it might be something preference or script-related but I'll probably do that soon.

However, I never do any of the steps described in the original report. It just seems like occasionally, when I'm undoing vandalism, when I go back to recent changes, the URL is the same as if I had my filter that I usually use, however for whatever reason the user-intent prediction filters are completely missing, even though the URL has them still part of the filter (although they don't do anything as they are basically removed from the filter completely). I'm able to fix it by going and doing something else for a few minutes and then going back to recent changes, however it's only temporary. If you think it would be helpful I could probably do a video recording of it happening.

I just found what is causing the filters to vanish. Don't know what causes the thing to happen but I've made progress. Occasionally,
&hidecategorization=1 gets added to the link. If I remove that part of the link my filters come back. Now, what is causing that to get added I don't know.

Nevermind, it appears to be associated with hiding edits to categories.

I have added Skarmory to this phab case as they too have stated they've had issues with recent changes filters disappearing.

This comment was removed by Vukky.

I think I figured out what's going on that causes the filter to break. For whatever reason

goodfaith=likelybad&

gets moved after

title=Special:RecentChanges

in the URL. So I think we've identified what is happening, now to figure out what is causing

I observed that as well, however I didn't say anything about it because the main bug seemed to happen irrespectively.

matmarex subscribed.

When the issue occurs, the "damaging" filter configuration is missing from mw.config.get( 'wgStructuredChangeFilters' ):

ExpectedBug
image.png (2×3 px, 499 KB)
image.png (2×3 px, 410 KB)

I think this indicates that the ORES extension thinks that the filter is not supposed to be available, and it's not just a bug in how the filters are displayed.