Maniphest T290151

WiKit: Add loading and readOnly states to TextArea
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ItamarWMDE
	Sep 1 2021, 12:50 PM

Tags

Referenced Files

	F34638066: Screenshot 2021-09-09 at 12.20.20.png
	Sep 9 2021, 10:22 AM

	F34638058: Screenshot 2021-09-09 at 12.11.35.png
	Sep 9 2021, 10:22 AM

Subscribers

Lydia_Pintscher

Mattia_Capozzi_WMDE

Description

In order to enable WiKit component implementers to specify a loading state through a prop, two visual states should be implemented in WiKit: loading, and read only.

The specifications for these states can be found on figma.

Each state should have:

A prop to pass the state to the component
Storybook entry when the prop is enabled in the All story
Controls to document and manipulate the prop through storybook

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mattia_Capozzi_WMDE	T290078 Create basic Results Page w/ client side item id submission with loading and read-only
		Resolved		ItamarWMDE	T290151 WiKit: Add loading and readOnly states to TextArea

Event Timeline

ItamarWMDE created this task.Sep 1 2021, 12:50 PM

ItamarWMDE updated the task description. (Show Details)Sep 1 2021, 12:53 PM

ItamarWMDE mentioned this in T290154: WiKit: Create a pre-release that includes the loading and readonly component states .Sep 1 2021, 12:58 PM

ItamarWMDE moved this task from To Do to Parents / Waiting on the Mismatch Finder (Mismatch Finder - sprint 6) board.

ItamarWMDE moved this task from Parents / Waiting to To Do on the Mismatch Finder (Mismatch Finder - sprint 6) board.

ItamarWMDE added a project: Wikidata Design System.Sep 1 2021, 1:01 PM

ItamarWMDE claimed this task.Sep 1 2021, 3:29 PM

ItamarWMDE moved this task from To Do to Doing on the Mismatch Finder (Mismatch Finder - sprint 6) board.

Notes from discussion with Sarai:

For the mixin, use keyframes and easings from https://codepen.io/saraisanchez/pen/abJeNrm
Create branch from both token draft PRS at:
- https://github.com/wmde/wikit/pull/458
- https://github.com/wmde/wikit/pull/456

Up for review:

PR #465: Add read-only state
PR #470: Add loading state

ItamarWMDE moved this task from Doing to Peer Review on the Mismatch Finder (Mismatch Finder - sprint 6) board.Sep 3 2021, 10:35 AM

ItamarWMDE moved this task from Peer Review to Test (Verification) on the Mismatch Finder (Mismatch Finder - sprint 6) board.Sep 6 2021, 8:01 AM

Great job! 💯

Non-blocking, small PR to adjust the speed (aka width) of the loader here: #479

Sarai-WMDE moved this task from Test (Verification) to Done on the Mismatch Finder (Mismatch Finder - sprint 6) board.Sep 9 2021, 9:50 AM

ItamarWMDE moved this task from Incoming to Done on the Wikidata Design System board.Sep 9 2021, 10:01 AM

Mattia_Capozzi_WMDE subscribed.Sep 9 2021, 10:22 AM

This comment was removed by Mattia_Capozzi_WMDE.

Mattia_Capozzi_WMDE added a comment.Sep 9 2021, 10:25 AM

This comment was removed by Mattia_Capozzi_WMDE.

\o/

Hello there,
Sorry for spamming twice with an irrelevant comment.
Everything seems to be fine also from my side on this ticket.
Great job!