Page MenuHomePhabricator

Suggested edits: filters with zero suggestions load SE card
Closed, ResolvedPublicBUG REPORT

Description

The issue happens only on the initial selection of filters/topics. To reproduce the issue there are two options - 1) a user enables Homepage (or it's enabled upon creating a new account) 2) use "Restore all default settings (in all sections) in User preferences.

mswiki (Malay wikipedia) has zero articles for performing arts topic for both copyedit and links (mswiki Special:NewcomerTaskInfo)

  • a user with enabled Special:Homepage goes through the intro tour
  • a user selects performing arts topis; the task difficulty selection is default: copyedit and links

Screen Shot 2021-09-01 at 5.57.20 PM.png (1×1 px, 247 KB)

    • a user might not notice the zero number for suggested articles and proceed
  • a user doesn't change the default filter selection and click on "Get suggestions"

Screen Shot 2021-09-01 at 5.57.32 PM.png (1×1 px, 203 KB)

  • 318 suggestions (the total number of tasks for the default filters) are displayed for default filters and performing arts topics

Screen Shot 2021-09-01 at 5.57.50 PM.png (1×1 px, 155 KB)

  • a user clicks on the arrow to get to the next article - the article is not displayed; "No more suggestions" message appears and the counter is out of sync with the actual number of tasks (0 number of task)
    Screen Shot 2021-09-01 at 5.57.58 PM.png (1×1 px, 130 KB)

Here is an animated gif:

wrong_counter3.gif (652×857 px, 206 KB)

Event Timeline

kostajh triaged this task as Medium priority.Mon, Sep 6, 10:17 AM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

Probably the server-side-generated card and count use default filter settings and aren't updated when the user changes the filters in the onboarding dialog.

Change 719998 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Update suggested edits module state from start editing dialog

https://gerrit.wikimedia.org/r/719998

From Patchset 2

  1. Clear preferences via new mw.Api().saveOption( 'growthexperiments-homepage-suggestededits-activated', '0' )
  2. Select "Art"
  3. Clear preferences again [This is when the screen recording below starts]
  4. Select "Architecture"
  5. Apply filters & open filters dialog —— in the dialog, "Art" is selected when "Architecture" is the selected topic

From Patchset 2

  1. Clear preferences via new mw.Api().saveOption( 'growthexperiments-homepage-suggestededits-activated', '0' )
  2. Select "Art"
  3. Clear preferences again [This is when the screen recording below starts]
  4. Select "Architecture"
  5. Apply filters & open filters dialog —— in the dialog, "Art" is selected when "Architecture" is the selected topic

The task type and topic filters are stored in separate preferences from the growthexperiments-homepage-suggestededits-activated setting, so yeah, weird things are happening here. Personally I would consider this to not be an issue worth addressing in code, though, because the user can't deactivate suggested edits through the UI, and adding additional code to handle scenarios that can be reached only via browser console snippets doesn't seem justified.

Change 719998 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update suggested edits module state from start editing dialog

https://gerrit.wikimedia.org/r/719998

Checked in betalabs - moving to Test in Production.