Page MenuHomePhabricator
Create Task
Maniphest T290236

Upgrade Gerrit from 3.3.5 to 3.3.6
Closed, ResolvedPublic
Actions

Description

New patch release should be deployed. https://www.gerritcodereview.com/3.3.html#336

Security fixes

Issue 14732: Commits/IncludedIn exposes branch names without respecting the ACLs on branches
Issue 7282: Hide repository name and description when user has no access

And bugs that got reported by us. At least:

T288035 Issue 14872: Disable setting cancelLeftPadding if avatars are not set in the config
T288193 Issue 13745: Firefox: fix suggested reviewers pop up instantly and not disappearing when out of focus

Details

ProjectBranchLines +/-Subject
operations/software/gerritdeploy/wmf/stable-3.3+13 -13Gerrit v3.3.6 and rebuild plugins
operations/software/gerritwmf/stable-3.3+1 -6Merge tag 'v3.3.6' into wmf/stable-3.3
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 2 2021, 10:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2021, 10:30 AM
hashar updated the task description. (Show Details)Sep 2 2021, 10:32 AM
hashar added a parent task: T288035: Gerrit names misalignment in 3.3.5.
hashar updated the task description. (Show Details)Sep 2 2021, 10:34 AM
hashar added a parent task: T288193: Can't dismiss reviewer autosuggestion dropdown in new Gerrit.
hashar added a parent task: T274699: Editing via the web interface, "Drag and drop a file here" does not accept files in "Add a new file or open an existing file".Sep 2 2021, 10:40 AM
gerritbot added a comment.Sep 2 2021, 1:56 PM

Change 716317 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.3] Gerrit v3.3.6

https://gerrit.wikimedia.org/r/716317

gerritbot added a project: Patch-For-Review.Sep 2 2021, 1:56 PM
dancy updated the task description. (Show Details)Sep 2 2021, 2:43 PM
brennen moved this task from INBOX to Doing on the Release-Engineering-Team board.Sep 2 2021, 2:46 PM
brennen edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team.
gerritbot added a comment.Sep 2 2021, 7:15 PM

Change 716485 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.3] Merge tag 'v3.3.6' into wmf/stable-3.3

https://gerrit.wikimedia.org/r/716485

gerritbot added a comment.Sep 24 2021, 12:40 PM

Change 716485 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.3] Merge tag 'v3.3.6' into wmf/stable-3.3

https://gerrit.wikimedia.org/r/716485

gerritbot added a comment.Oct 7 2021, 2:20 PM

Change 716317 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.3] Gerrit v3.3.6 and rebuild plugins

https://gerrit.wikimedia.org/r/716317

Stashbot added a comment.Oct 7 2021, 2:48 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T14:48:54Z] <hashar> Upgrading Gerrit replica to 3.3.6 # T290236

hashar changed the task status from Open to In Progress.Oct 7 2021, 3:05 PM
ssh -p 29418 gerrit-replica.wikimedia.org gerrit plugin ls
Name                           Version    Api-Version      Status   File
-------------------------------------------------------------------------------
codemirror-editor              v3.3.6     3.3.6            ENABLED  codemirror-editor.jar
commit-message-length-validator v3.3.6     3.3.6            ENABLED  commit-message-length-validator.jar
delete-project                 v3.3.6     3.3.6            ENABLED  delete-project.jar
download-commands              v3.3.6     3.3.6            ENABLED  download-commands.jar
gitiles                        v3.3.6-5-g2a1dca2 3.3.6            ENABLED  gitiles.jar
go-import                      c60764c    3.3.6            ENABLED  go-import.jar
healthcheck                    v3.3.0-24-g825e28b 3.3.6            ENABLED  healthcheck.jar
hooks                          v3.3.6     3.3.6            ENABLED  hooks.jar
its-phabricator                d6a9913    3.3.6            ENABLED  its-phabricator.jar
javamelody                     v2.14-409-g3202fe1 3.3.6            ENABLED  javamelody.jar
lfs                            0b47095    3.3.6            ENABLED  lfs.jar
metrics-reporter-jmx           ffe1a46    3.3.6            ENABLED  metrics-reporter-jmx.jar
metrics-reporter-prometheus    0de17ef    3.3.6            ENABLED  metrics-reporter-prometheus.jar
motd                           3d174f8    3.3.6            ENABLED  motd.jar
plugin-manager                 v3.3.6     3.3.6            ENABLED  plugin-manager.jar
replication                    v3.3.6     3.3.6            ENABLED  replication.jar
reviewers                      378d16f    3.3.6            ENABLED  reviewers.jar
reviewnotes                    v3.3.6     3.3.6            ENABLED  reviewnotes.jar
singleusergroup                v3.3.6     3.3.6            ENABLED  singleusergroup.jar
webhooks                       v3.3.6     3.3.6            ENABLED  webhooks.jar
zuul                           f406179    3.3.6            ENABLED  zuul.jar
hashar added a comment.Oct 7 2021, 3:11 PM

gerrit.wikimedia.org updated:

Name                           Version    Api-Version      Status   File
-------------------------------------------------------------------------------
codemirror-editor              v3.3.6     3.3.6            ENABLED  codemirror-editor.jar
commit-message-length-validator v3.3.6     3.3.6            ENABLED  commit-message-length-validator.jar
delete-project                 v3.3.6     3.3.6            ENABLED  delete-project.jar
download-commands              v3.3.6     3.3.6            ENABLED  download-commands.jar
gitiles                        v3.3.6-5-g2a1dca2 3.3.6            ENABLED  gitiles.jar
go-import                      c60764c    3.3.6            ENABLED  go-import.jar
healthcheck                    v3.3.0-24-g825e28b 3.3.6            ENABLED  healthcheck.jar
hooks                          v3.3.6     3.3.6            ENABLED  hooks.jar
its-phabricator                d6a9913    3.3.6            ENABLED  its-phabricator.jar
javamelody                     v2.14-409-g3202fe1 3.3.6            ENABLED  javamelody.jar
lfs                            0b47095    3.3.6            ENABLED  lfs.jar
metrics-reporter-jmx           ffe1a46    3.3.6            ENABLED  metrics-reporter-jmx.jar
metrics-reporter-prometheus    0de17ef    3.3.6            ENABLED  metrics-reporter-prometheus.jar
motd                           3d174f8    3.3.6            ENABLED  motd.jar
plugin-manager                 v3.3.6     3.3.6            ENABLED  plugin-manager.jar
replication                    v3.3.6     3.3.6            ENABLED  replication.jar
reviewers                      378d16f    3.3.6            ENABLED  reviewers.jar
reviewnotes                    v3.3.6     3.3.6            ENABLED  reviewnotes.jar
singleusergroup                v3.3.6     3.3.6            ENABLED  singleusergroup.jar
webhooks                       v3.3.6     3.3.6            ENABLED  webhooks.jar
zuul                           f406179    3.3.6            ENABLED  zuul.jar
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 3:11 PM
hashar closed this task as Resolved.Oct 7 2021, 3:18 PM
hashar claimed this task.

Finally I have deployed the update. With the[[https://wikitech.wikimedia.org/wiki/Gerrit/Upgrade | upgrade runbook]] the downtime has been minimal.

Changelog is at https://www.gerritcodereview.com/3.3.html#336

And it should address:

hashar added a parent task: T282387: Can't type slash character ("/") in Gerrit web editor [fixed in Gerrit 3.3.6].Oct 11 2021, 9:45 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL