This task is to monitor refactoring code development.
Many improvements will be added. For example:
- Breaking home.jsx page into smaller file
- Using react functional components
- Updating packages
- Adding better ESLint rules for react
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Combine backend and worker with frontend | labs/tools/VideoCutTool | master | +50 K -19 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Gopavasanth | T249993 Split home.js into different components | |||
| Resolved | Khr2003 | T290241 Refactor main code |
Event Timeline
Comment Actions
Change 716255 had a related patch set uploaded (by Khr2003; author: Khr2003):
[labs/tools/VideoCutTool@master] Major update. Refactor code
Comment Actions
Thanks! (For good practices and better reviewability, in the future I recommend to write small, atomic commits. Just saying. :) )
Comment Actions
Totally fair point. I was trying to improve the trim UI and then ended up with a code overwrite.
Here is an online version of the tool (somewhat older than the code I pushed): https://videocuttools.herokuapp.com/
and this is a screenshot:
Comment Actions
Hi @Khr2003, That's so nice!! I've tried out the tool and this new look and feel seems AMAZING! I've noted few things and would like to hear your thoughts on them :)
- As shown in the below image, Video player seems to be placed top of the screen, May be adding a little bit of padding would look good?
- As per the below image, the video trimmer sliders can't be set to below 3sec for this video and for the another video it's 12sec's, How is this lower limit generating? I think we also need to provide the option to users for manually entering the From and To trim options along with this sliders for their accuracy purpose.
 |  |
- Seems like the tool isn't properly fit in the mobile screens?
- How about moving the footer credits from the sidebar to the main screen?
- Icons are same here, we may change the icon for the split in to multiple videos option.
 |  |
- We can change the string from "Choose locale" to "Choose your language", when the user clicks on the language dropdown?
Comment Actions
@Gopavasanth
I fixed the issues. The design is mobile ready. I am not sure why you are seeing this. There should be a hamburger menu icon to toggle sidebar.
Comment Actions
Thanks @Khr2003
- When I pull your patch and start the app, Its failing to compile saying: https://ibb.co/H7WYgGJ
- In light theme the footer is not visible
- Jenkins is failing so how about removing "src/App.test.js" if this is not so useful for us?
Comment Actions
Change 716255 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Combine backend and worker with frontend