Description
Vector menus all use the 'vector-menu-heading' class, but our CSS usually directly uses h3 in the selectors. Using the class will reduce CSS specificity and is more readable/maintainable long term because the styles are less dependent on the HTML.
We also want to replace the h3 element in modern vector with a non heading element like a div to avoid messing up the heading structure
AC
- Instances of h3 are removed from Menu CSS and replaced with vector-menu-heading
- h3 elements are replaced with label elements in modern vector
- All menu styles remain the same in Vector and legacy Vector. Menus in this context include all "dropdown menus", "tab menus", and "portlet menus" (https://phabricator.wikimedia.org/F34972677)
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ⬜ | T290280#7764249 |
2 | ✅ | T290280#7764249 |
3 | ✅ | T290280#7764249 |
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T290280#7779620 |
2 | ✅ | T290280#7772832 T290280#7779620 |
3 | ✅ | T290280#7772832 |