Maniphest T290312

Unwanted animation when filters are closed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Sep 3 2021, 10:16 AM

Tags

Referenced Files

	F34636967: se_filters_noAnimation.gif
	Sep 8 2021, 4:48 PM

	F34630608: swipe-bug.webm
	Sep 3 2021, 10:16 AM

Subscribers

Description

This is a follow-up to T268709: Add a link: mobile swiping gesture in suggested edits feed . When opening the filters and then closing them (no change), the existing card is animated in.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Suggested Edits: Set isFirstRender to true when filters dialog is closed	mediawiki/extensions/GrowthExperiments	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned Here: T268709: Add a link: mobile swiping gesture in suggested edits feed

Event Timeline

kostajh created this task.Sep 3 2021, 10:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2021, 10:16 AM

kostajh triaged this task as Medium priority.Sep 3 2021, 10:16 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr subscribed.Sep 3 2021, 6:00 PM

• mewoph claimed this task.Sep 8 2021, 3:51 PM

• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 719561 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Set isFirstRender to true when filters dialog is closed

https://gerrit.wikimedia.org/r/719561

gerritbot added a project: Patch-For-Review.Sep 8 2021, 4:47 PM

With latest changes:

se_filters_noAnimation.gif (1×752 px, 3 MB)

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 9 2021, 8:22 AM

Change 719561 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Set isFirstRender to true when filters dialog is closed

https://gerrit.wikimedia.org/r/719561

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 9 2021, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2021, 9:10 AM

Checked in betalabs - the new selection of topics/difficulty levels won't add the animation.

Etonkovidova closed this task as Resolved.Sep 14 2021, 10:20 PM