| Reedy | |
| Sep 3 2021, 11:33 PM |
| F34632106: Screenshot 2021-09-04 at 12.52.41.png | |
| Sep 4 2021, 11:54 AM |
| F34632108: Screenshot 2021-09-04 at 12.54.07.png | |
| Sep 4 2021, 11:54 AM |
Following on from T289086: Allow iOS/macOS/iPadOS to autofill 2fa codes, we should improve/set the autocomplete values for usernames and passwords on the Login and signup forms
Use the following autocomplete attribute values:
| Credential | Autocomplete Values |
|---|---|
| User Name | username |
| Password | current-password |
| New Password | new-password |
| One-Time Code | one-time-code |
See also: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
Doing a quick search in the code (for core), it looks like we pretty much already use these values for autocomplete.
It looks like we do for registration, but not for the login form. So we should at least make it consistent...
The code for the login form does seem to set autocomplete values (https://github.com/wikimedia/mediawiki/blob/51b5edd2adb5b33d6cc042df2aae5175144a0640/includes/specialpage/LoginSignupSpecialPage.php#L905) but they don’t take effect on the login form I checked the web inspector for both wikipedia, and a different wiki, and I am seeing autocomplete values that are correct.
Closing as invalid, as when I look in the web console on Wikipedia as well as another wiki, and when I look at the MW code, I see that the correct autocomplete values are set.