wgGEHomepageMentorsList is invalid
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.37.0-wmf.21
reqId: 1cd431c7-ffe6-4bee-841a-d29d3db35ad9
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

No mentor available for {user}

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/Mentorship/MentorPageMentorManager.php(288)
#0 /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/Mentorship/MentorPageMentorManager.php(214): GrowthExperiments\Mentorship\MentorPageMentorManager->getMentorsPage()
#1 /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/Mentorship/MentorPageMentorManager.php(233): GrowthExperiments\Mentorship\MentorPageMentorManager->getAutoAssignedMentors()
#2 /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/Mentorship/MentorPageMentorManager.php(137): GrowthExperiments\Mentorship\MentorPageMentorManager->getRandomAutoAssignedMentor(User)
#3 /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/Mentorship/MentorPageMentorManager.php(146): GrowthExperiments\Mentorship\MentorPageMentorManager->getMentorForUser(User)
#4 /srv/mediawiki/php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/HelpPanelHooks.php(150): GrowthExperiments\Mentorship\MentorPageMentorManager->getMentorForUserSafe(User)
#5 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookContainer.php(338): GrowthExperiments\HelpPanelHooks::onBeforePageDisplay(OutputPage, SkinMinerva)
#6 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#7 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookRunner.php(942): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#8 /srv/mediawiki/php-1.37.0-wmf.21/includes/OutputPage.php(2639): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinMinerva)
#9 /srv/mediawiki/php-1.37.0-wmf.21/includes/MediaWiki.php(939): OutputPage->output(boolean)
#10 /srv/mediawiki/php-1.37.0-wmf.21/includes/MediaWiki.php(952): MediaWiki::{closure}()
#11 /srv/mediawiki/php-1.37.0-wmf.21/includes/MediaWiki.php(559): MediaWiki->main()
#12 /srv/mediawiki/php-1.37.0-wmf.21/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.37.0-wmf.21/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Impact

1,530 reports (the last timestamp Sep 4, 2021 @ 00:31:43.480)
INFO level
checked Special::EditGrowthConfig on jawiki and eswiki - the Mentorship is enabled, but the pages with the list of mentors are not given
the reports were not on the Growth dashboard

Details

Request URL: https://ja.wikipedia.org/wiki/%E3%82%B6%E3%83%BB%E3%83%AD%E3%83%B3%E3%82%B0%E3%83%BB%E3%82%A2%E3%83%B3%E3%83%89%E3%83%BB%E3%83%AF%E3%82%A4%E3%83%B3%E3%83%87%E3%82%A3%E3%83%B3%E3%82%B0%E3%83%BB%E3%83%AD%E3%83%BC%E3%83%89

Subject	Repo	Branch	Lines +/-
MentorManager::getMentorForUserSafe: Do not log instances of WikiConfigException	mediawiki/extensions/GrowthExperiments	master	+2 -6
MentorManager::getRandomAutoAssignedMentor should not throw if no mentors are available	mediawiki/extensions/GrowthExperiments	master	+29 -14
MentorManager: Mentor list methods should not throw WikiConfigException for missing mentor list	mediawiki/extensions/GrowthExperiments	master	+53 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		MShilova_WMF	T304427 [Epic] Q4 FY 2021-22 Growth Maintenance Work
		Resolved	PRODUCTION ERROR	Urbanecm_WMF	T290371 wgGEHomepageMentorsList is invalid

Event Timeline

Etonkovidova created this task.Sep 4 2021, 12:36 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2021, 12:36 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Etonkovidova updated the task description. (Show Details)Sep 4 2021, 12:38 AM

Etonkovidova added subscribers: Tgr, Urbanecm_WMF, kostajh, • mewoph.

Krinkle moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Sep 5 2021, 12:21 AM

@Urbanecm_WMF AFAIK this isn't a problem, but maybe there's something we should do about reducing the log levels?

In T290371#7333724, @kostajh wrote:

@Urbanecm_WMF AFAIK this isn't a problem, but maybe there's something we should do about reducing the log levels?

It's not a user-facing problem, but it logs a lot of INFO-level messages now that most wikis we're deployed to do not have a mentor list. I think WikiConfigException should not be thrown at all if the page is simply missing from the config, as we accept that as a valid configuration. I'll upload a patch that makes a difference between a) mentor list is not configured b) mentor list is configured in an invalid way.

This should stop logging messages for wikis where the mentor list is missing, but keep them if a wiki manages to set an invalid value for the variable (which is probably important for us to know).

Once that patch gets deployed, we might even consider increasing the log level to WARNING (or even ERROR), so invalid list is caught during chores.

Urbanecm_WMF triaged this task as Lowest priority.Sep 6 2021, 10:52 AM

Change 719061 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorManager: Throw WikiConfigException only if mentor list is invalid

https://gerrit.wikimedia.org/r/719061

gerritbot added a project: Patch-For-Review.Sep 6 2021, 10:55 AM

This is not a production error; it is logged into a dedicated channel (GrowthExperiments) that does not appear in standard error dashboards.

Moving to sprint, as I uploaded a patch that needs CR.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 6 2021, 10:57 AM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.

Change 719061 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorManager: Mentor list methods should not throw WikiConfigException for missing mentor list

https://gerrit.wikimedia.org/r/719061

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 9 2021, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2021, 5:10 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 9 2021, 6:21 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 9 2021, 7:10 PM

Checked on wmf.23 - the info-level messages are still present (link for normalized_message:"No mentor available for {user}".
There are also a messages that include individual user names (the same link as for the normalized message).

@Urbanecm_WMF - there should be a follow-up patch as per commit message on https://gerrit.wikimedia.org/r/719061?

Yep yep, moving to In progress again.

Change 721986 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorManager::getRandomAutoAssignedMentor should not throw if no mentors are available

https://gerrit.wikimedia.org/r/721986

gerritbot added a project: Patch-For-Review.Sep 18 2021, 3:17 PM

Change 721986 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorManager::getRandomAutoAssignedMentor should not throw if no mentors are available

https://gerrit.wikimedia.org/r/721986

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2021, 5:11 AM

Tgr moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 21 2021, 6:11 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 21 2021, 4:00 PM

Urbanecm_WMF moved this task from In review to Backlog on the User-Urbanecm_WMF (Engineering) board.Sep 23 2021, 6:42 PM

Urbanecm_WMF moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Urbanecm_WMF removed Urbanecm_WMF as the assignee of this task.Jan 16 2022, 12:40 PM

Urbanecm_WMF edited projects, added Growth-Team; removed User-Urbanecm_WMF (Engineering), Growth-Team (Sprint 0 (Growth Team)).

This still needs some treatment (see Logstash), but i'm not actively working on this those days.

In T290371#7624620, @Urbanecm_WMF wrote:

This still needs some treatment (see Logstash), but i'm not actively working on this those days.

Checked the link "Mentorship: No mentor available" message in Logstash - a high number of hits just for the one day (363,115).

In T290371#7716477, @Etonkovidova wrote:

In T290371#7624620, @Urbanecm_WMF wrote:

This still needs some treatment (see Logstash), but i'm not actively working on this those days.

Checked the link "Mentorship: No mentor available" message in Logstash - a high number of hits just for the one day (363,115).

Thanks for checking that @Etonkovidova. Putting this in the current sprint for us to do something about reducing the volume of Logspam.

@Urbanecm_WMF I think we should do something about this Logspam; is that something you could work on in the context of the GrowthExperiments-Mentorship work?

kostajh added a parent task: T304427: [Epic] Q4 FY 2021-22 Growth Maintenance Work.Apr 6 2022, 1:41 PM

In T290371#7835279, @kostajh wrote:

@Urbanecm_WMF I think we should do something about this Logspam; is that something you could work on in the context of the GrowthExperiments-Mentorship work?

Sure thing. I'll have a look at it. Thanks for the ping!

Change 778610 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorManager::getMentorForUserSafe: Do not log instances of WikiConfigException

https://gerrit.wikimedia.org/r/778610

gerritbot added a project: Patch-For-Review.Apr 9 2022, 11:54 AM

Urbanecm_WMF claimed this task.Apr 9 2022, 11:59 AM

Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptApr 9 2022, 11:59 AM

Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Apr 9 2022, 11:59 AM

Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.

MShilova_WMF moved this task from New Tasks to Backlog on the GrowthExperiments-Mentorship board.Apr 15 2022, 4:11 PM

Change 778610 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorManager::getMentorForUserSafe: Do not log instances of WikiConfigException

https://gerrit.wikimedia.org/r/778610

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 17 2022, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2022, 10:30 PM

Message should be gone now (hopefully).

Checked in betalabs logs - the error's last timestamp is Apr 17, 2022 @ 14:42:36.361 which is a good indication that the fix is working. Moving to Test in Production.

Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Apr 22 2022, 2:34 PM

Etonkovidova closed this task as Resolved.Apr 26 2022, 11:30 PM

wgGEHomepageMentorsList is invalidClosed, ResolvedPublicPRODUCTION ERRORActions