Page MenuHomePhabricator
Create Task
Maniphest T290464

Bundle DiscussionTools extension with MediaWiki
Closed, ResolvedPublic
Actions

Description

DiscussionTools fills a large and painful gap MediaWiki's communication capabilities. Even in its current experimental state, I think it's worth offering it as part of the default experience; and with VisualEditor now being part of the bundle, it doesn't seem too complicated.

  • Passed security review or already Wikimedia deployed
  • Voting CI structure tests
  • Runs MediaWiki-CodeSniffer
  • Runs phan
  • Supports MySQL, SQLite, and Postgres (uses abstract schema)
  • GPL v2 or later compatible license (MIT)
  • Extension's default configuration provides optimal experience
  • Tested with web installer
  • Any relevant dependencies/enhancing extensions also bundled (Linter: T290465)

Details

SubjectRepoBranchLines +/-
HISTORY: Add DiscussionTools bundling to 1.40 release notesmediawiki/coremaster+3 -1
Add DiscussionTools bundling to release notesmediawiki/coreREL1_40+3 -1
Change $wgExperimentalHtmlIds to HTML5-firstmediawiki/coremaster+5 -1
Add DiscussionTools to the default MediaWiki bundlemediawiki/tools/releasemaster+1 -0
Installer: Add $wgLocaltimezone to LocalSettings templatemediawiki/coreREL1_37+9 -5
Installer: Add $wgLocaltimezone to LocalSettings templatemediawiki/coremaster+9 -5
MWInternalLinkAnnotation: Make test work with both fragment modesmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2021, 4:35 AM
Tgr moved this task from Blocker to Bundling on the MW-1.38-release board.Sep 7 2021, 4:35 AM
Tgr updated the task description. (Show Details)Sep 7 2021, 4:44 AM
Tgr renamed this task from Bundle DiscussionTools with MediaWiki to Bundle DiscussionTools extension with MediaWiki.Sep 7 2021, 4:48 AM
Tgr mentioned this in T290465: Bundle Linter extension with MediaWiki.Sep 7 2021, 4:52 AM
Tgr updated the task description. (Show Details)

Seems like there isn't much to do here other than testing it out, so maybe even doable for 1.37?

Tgr updated the task description. (Show Details)Sep 7 2021, 5:14 AM
matmarex subscribed.Sep 7 2021, 11:19 AM

DiscussionTools currently requires non-default values for two configuration settings, $wgLocaltimezone and $wgFragmentMode: https://phabricator.wikimedia.org/diffusion/EDTO/browse/master/includes/Hooks/RegistrationHooks.php

$wgLocaltimezone must be non-null, so that timestamps remain consistent during daylight-saving time. As far as I can see, the installer does not set it. Maybe the auto-detection that currently is in Setup.php could be in the installer instead.

$wgFragmentMode must be 'html5'-first, which behaves more sensibly and made our code easier to write. We could probably support 'legacy'-first too but it would take some work. Alternatively, maybe 'html5'-first could become the default in MediaWiki (it's been used in WMF production for a while now).

ppelberg added a project: Editing-team (Tracking).Sep 9 2021, 3:15 PM
ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
ppelberg subscribed.
ppelberg added a comment.Sep 9 2021, 3:18 PM

@Tgr I'm glad you filed this task; we agree we think bundling DiscussionTools with MediaWiki. Although, we cannot prioritize work on this right now.

In the meantime, f you – or anyone else – is motivated to resolve the blockers @matmarex raised in T290464#7335873, we will review them.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Sep 9 2021, 3:18 PM
gerritbot added a comment.Sep 11 2021, 8:49 AM

Change 720427 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Change $wgExperimentalHtmlIds to HTML5-first

https://gerrit.wikimedia.org/r/720427

gerritbot added a project: Patch-For-Review.Sep 11 2021, 8:49 AM
gerritbot added a comment.Sep 12 2021, 12:41 AM

Change 720460 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/VisualEditor@master] MWInternalLinkAnnotation: Make test work with both fragment modes

https://gerrit.wikimedia.org/r/720460

Darkdeath-2 subscribed.Sep 12 2021, 12:57 AM
gerritbot added a comment.Sep 12 2021, 4:32 AM

Change 720460 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWInternalLinkAnnotation: Make test work with both fragment modes

https://gerrit.wikimedia.org/r/720460

gerritbot added a comment.Sep 12 2021, 4:32 AM

Change 720427 merged by jenkins-bot:

[mediawiki/core@master] Change $wgExperimentalHtmlIds to HTML5-first

https://gerrit.wikimedia.org/r/720427

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 12 2021, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 12 2021, 5:10 AM
gerritbot added a comment.Sep 12 2021, 4:54 PM

Change 720475 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Installer: Add $wgLocaltimezone to LocalSettings template

https://gerrit.wikimedia.org/r/720475

gerritbot added a project: Patch-For-Review.Sep 12 2021, 4:54 PM
Tgr added a subtask: T290465: Bundle Linter extension with MediaWiki.Sep 12 2021, 6:55 PM
Tgr updated the task description. (Show Details)
Tgr edited projects, added MW-1.37-release; removed MW-1.38-release.

Seems to work fine with the patches applied.

This turned out to be pretty simple, could as well go into the current release.

matmarex added a comment.Sep 12 2021, 7:47 PM

:o Thanks!

Tgr moved this task from Blocker to Bundling on the MW-1.37-release board.Sep 12 2021, 11:41 PM
Tgr added a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.
Tgr mentioned this in T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Sep 12 2021, 11:45 PM
gerritbot added a comment.Sep 12 2021, 11:50 PM

Change 720490 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/tools/release@master] Add DiscussionTools to the default MediaWiki bundle

https://gerrit.wikimedia.org/r/720490

ppelberg awarded a token.Sep 13 2021, 4:59 AM
ppelberg added a comment.EditedSep 13 2021, 5:41 PM

@Tgr: are you able to share how the experience of someone setting up a MediaWiki instance will be impacted by DiscussionTools being included in the default bundle? E.g. as the patches are currently written, what DiscussionTools features are enabled [i]? Are they enabled by default? Are they "nested" within the DiscussionTools beta feature? Is said beta feature enabled/disabled by default?

For context, while we are actively making changes to the DiscussionTools extension, we're keen for everyone to have access to features available within it [i], provided the following is true:

  1. People need to manually opt-it to enabling the features
  2. People are aware they should expect changes to the extension as it is under active development

i. Reply Tool, New Discussion Tool, Topic Subscriptions

Tgr mentioned this in T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:19 AM
Tgr edited projects, added MW-1.38-release; removed MW-1.37-release.Sep 14 2021, 12:29 AM
Tgr added a parent task: T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:30 AM
Tgr added a comment.Sep 14 2021, 12:48 AM

Per the discussion in T279842 it won't make it into this release, but in general, there would be a checkbox to enable DiscussionTools like there is for the other bundled extensions/skins, and if it's checked the wfLoadExtension call would be added to LocalSettings.php. All settings would be at their default value (ie. what's set in the extension's extension.json file).

matmarex added a comment.Sep 14 2021, 1:51 AM

Also, we may want to remove or change the "Share feedback about this feature" links. In the past such links in various products resulted in mostly useless feedback (T188729, T209336). If we want to hear from users of third-party wikis, we might want to send them to a different page?

Tgr added a comment.Sep 14 2021, 2:36 AM

Yeah, that's best disabled by default. The majority of such feedback is either configuration issues specific to that wiki, or several years outdated since many wikis don't update regularly.

gerritbot added a comment.Sep 21 2021, 3:43 PM

Change 720475 merged by jenkins-bot:

[mediawiki/core@master] Installer: Add $wgLocaltimezone to LocalSettings template

https://gerrit.wikimedia.org/r/720475

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 21 2021, 4:00 PM
• E.botha subscribed.Sep 22 2021, 5:16 PM
gerritbot added a comment.Sep 22 2021, 8:30 PM

Change 722905 had a related patch set uploaded (by Jforrester; author: Gergő Tisza):

[mediawiki/core@REL1_37] Installer: Add $wgLocaltimezone to LocalSettings template

https://gerrit.wikimedia.org/r/722905

gerritbot added a comment.Sep 22 2021, 8:41 PM

Change 722905 merged by jenkins-bot:

[mediawiki/core@REL1_37] Installer: Add $wgLocaltimezone to LocalSettings template

https://gerrit.wikimedia.org/r/722905

ReleaseTaggerBot edited projects, added MW-1.37-notes; removed MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 22 2021, 9:00 PM
Jdforrester-WMF mentioned this in T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Mar 30 2022, 3:14 PM
Jdforrester-WMF added a parent task: T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.
Jdforrester-WMF edited projects, added MW-1.39-release; removed MW-1.38-release.
Jdforrester-WMF moved this task from Blocker to Bundling on the MW-1.39-release board.Mar 30 2022, 3:18 PM
Jdforrester-WMF removed a parent task: T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.
Lectrician1 awarded a token.Mar 30 2022, 5:00 PM
Reedy mentioned this in T317146: Expand the set of bundled extensions and skins in MediaWiki 1.40.Sep 7 2022, 1:18 AM
Reedy added a parent task: T317146: Expand the set of bundled extensions and skins in MediaWiki 1.40.
Jdforrester-WMF removed a parent task: T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Sep 8 2022, 3:57 PM
gerritbot added a comment.Sep 8 2022, 7:00 PM

Change 720490 merged by jenkins-bot:

[mediawiki/tools/release@master] Add DiscussionTools to the default MediaWiki bundle

https://gerrit.wikimedia.org/r/720490

Jdforrester-WMF subscribed.Sep 8 2022, 7:01 PM

Will need to add some documentation to the release notes and the on-wiki docs. Otherwise this is done.

matmarex added a comment.Sep 9 2022, 12:15 AM

I think removing the "Share feedback…" is a release blocker.

Also, I was just testing and realized that we don't have a dependency on the Echo extension, even though some features don't work with it. (Surprisingly the wiki doesn't crash, but you never receive notifications for your subscriptions.) However, Echo isn't bundled yet…

Tacsipacsi subscribed.Sep 9 2022, 11:14 AM
In T290464#8223642, @matmarex wrote:

Also, I was just testing and realized that we don't have a dependency on the Echo extension, even though some features don't work with it. (Surprisingly the wiki doesn't crash, but you never receive notifications for your subscriptions.) However, Echo isn't bundled yet…

What about defaulting $wgDiscussionTools_topicsubscription and $wgDiscussionTools_autotopicsub to unavailable unless Echo is loaded? DiscussionTools makes sense even without topic subscriptions.

Reedy subscribed.Sep 9 2022, 11:20 AM
In T290464#8223642, @matmarex wrote:

I think removing the "Share feedback…" is a release blocker.

You've got till 1.40 ;)

Reedy edited projects, added MW-1.40-release; removed MW-1.39-release.Sep 25 2022, 4:50 PM
Reedy moved this task from Blocker to Bundling on the MW-1.40-release board.Sep 25 2022, 4:51 PM
matmarex mentioned this in T322494: Remove the "Share feedback about this feature" link for non-WMF wikis.Nov 6 2022, 9:03 PM
matmarex added a subtask: T322494: Remove the "Share feedback about this feature" link for non-WMF wikis.Nov 6 2022, 9:06 PM
matmarex mentioned this in T322498: Make the optional Echo dependency work better.
matmarex added a subtask: T322498: Make the optional Echo dependency work better.
ppelberg closed subtask T322494: Remove the "Share feedback about this feature" link for non-WMF wikis as Resolved.Nov 19 2022, 1:18 AM
ppelberg closed subtask T322498: Make the optional Echo dependency work better as Resolved.
Izno removed a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Dec 28 2022, 10:00 PM
Bugreporter2 awarded a token.Jan 14 2023, 5:25 AM
Bugreporter2 subscribed.
Jdforrester-WMF closed subtask T290465: Bundle Linter extension with MediaWiki as Resolved.Feb 7 2023, 6:03 PM
Jdforrester-WMF added a comment.Feb 7 2023, 6:09 PM
In T290464#8224464, @Reedy wrote:
In T290464#8223642, @matmarex wrote:

I think removing the "Share feedback…" is a release blocker.

You've got till 1.40 ;)

With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/853992 can we declare this Resolved?

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 6:31 PM
matmarex closed this task as Resolved.Feb 8 2023, 9:20 PM

Yeah!

Kghbln subscribed.EditedJul 5 2023, 11:56 AM

Hmm, is this extension bundled or not? On its page on mediawiki.org is still marked as a beta with no information about it being bundled. Moreover, the release notes of MW 1.40, this part got me asking here, do not mention it: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/REL1_40/RELEASE-NOTES-1.40#35

Kghbln added a comment.Jul 5 2023, 12:10 PM

Self answering. I just downloaded the 1.40.0 zip, and it is there. I updated the docu and will create a pull request to add this info to the release notes.

Kghbln added a comment.EditedJul 5 2023, 12:20 PM

Somehow I get many errors when submitting the patch to add a note about this extension to the release notes. It would be cool if someone on this task could do it. Thanks.

Tgr added a comment.EditedJul 5 2023, 5:27 PM
In T290464#8990455, @Kghbln wrote:

Somehow I get many errors when submitting the patch to add a note about this extension to the release notes. It would be cool if someone on this task could do it. Thanks.

FWIW you can go to the "Commands" tab of the component's repo settings in Gerrit ( https://gerrit.wikimedia.org/r/admin/repos/mediawiki/core,commands ), click Create change, and edit the changelog in Gerrit. Not the most convenient but you don't have to deal with any git weirdness.

gerritbot added a comment.Jul 5 2023, 5:30 PM

Change 935496 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@REL1_40] Add DiscussionTools bundling to release notes

https://gerrit.wikimedia.org/r/935496

gerritbot added a project: Patch-For-Review.Jul 5 2023, 5:30 PM
gerritbot added a comment.Jul 6 2023, 12:43 AM

Change 935496 merged by jenkins-bot:

[mediawiki/core@REL1_40] Add DiscussionTools bundling to release notes

https://gerrit.wikimedia.org/r/935496

ReleaseTaggerBot added a project: MW-1.40-notes.Jul 6 2023, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 6 2023, 1:10 AM
Kghbln added a comment.Jul 6 2023, 6:39 AM

@Tgr Thank you for extending the release notes and for your tip about web editing with Gerrit. I was not aware at all that this is possible. I was a bit in a hurry yesterday which is why I was not able to continue getting the patch done. :|

gerritbot added a comment.Jul 10 2023, 6:46 PM

Change 936786 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HISTORY: Add DiscussionTools bundling to 1.40 release notes

https://gerrit.wikimedia.org/r/936786

gerritbot added a project: Patch-For-Review.Jul 10 2023, 6:46 PM
gerritbot added a comment.Jul 10 2023, 7:03 PM

Change 936786 merged by jenkins-bot:

[mediawiki/core@master] HISTORY: Add DiscussionTools bundling to 1.40 release notes

https://gerrit.wikimedia.org/r/936786

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 7:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits