Page MenuHomePhabricator

Adjust the "For later" list presentation and access
Closed, ResolvedPublic

Description

After the initial iteration on the "For later" list (T260168), there are a couple aspects that need adjustment:

  • Present the list separate from the suggestions
  • Support the bookmark action on the Confirmation step

Present the list separate from the suggestions

The "for later" list was added as a section of the "Suggestions" list. However, it should be a separate list showing above Suggestions instead (as it is in Content Translation). I'll add screenshots of both for a more visual comparison between both tools:

"For later" in Content Translation (separate)"For later" in Section Translation (combined with suggestions)
cx-for-later.png (1×2 px, 229 KB)
sx-for-later.png (1×2 px, 323 KB)

Given that the "For later" items get not affected by the language selector or the "Refresh suggestions" options, it is preferred to show them in their own separate list as more persistent items.

Support the bookmark action on the Confirmation step

The bookmark action in the confirmation step (T241587) does not seem to be working:

  • The bookmark icon should reflect whether the article is already in the "For later" list or not.
  • Taping the bookmark icon will switch between the empty ("bookmarkOutline") and filled ("bookmark") version of the icon. The filled version will be rendered in blue (Accent50: #36c).

Event Timeline

Change 720347 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Present the favorites list separate from the suggestions

https://gerrit.wikimedia.org/r/720347

Change 720348 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Enable bookmark action

https://gerrit.wikimedia.org/r/720348

Change 720347 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Present the favorites list separate from the suggestions

https://gerrit.wikimedia.org/r/720347

Change 720348 merged by Santhosh:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Enable bookmark action

https://gerrit.wikimedia.org/r/720348

Jpita added a subscriber: Jpita.

when we are in the start translation page, after clicking the bookmark icon, it stays with this weird line around it while it has the focus.

image.png (134×120 px, 1 KB)

is this ok @Pginer-WMF ?

when we are in the start translation page, after clicking the bookmark icon, it stays with this weird line around it while it has the focus.

image.png (134×120 px, 1 KB)

is this ok @Pginer-WMF ?

For accessibility purposes, buttons (even those without borders) have this blue outline when focused. You can move around with the "tab" key switching the focus. So we need to support such behaviour. However, a valid question would be whether the button should remain focused after being pressed. Since there is ongoing work to standardize the vue-based UI library, I'd leave such decisions to the corresponding team, and we can just use the standard components.

In short: yes, it is ok to have the blue outline visible for now.