Page MenuHomePhabricator
Create Task
Maniphest T290492

VE dialog margins/spacing off
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Requirement

  • More/less button should be aligned with the right side of the input fields

Nice to have

  • The symbols to the right of the parameter names (i for deprecated) should have a space between the name and the symbol

Screen Shot 2021-09-07 at 10.19.37.png (514×1 px, 91 KB)

Details

SubjectRepoBranchLines +/-
Hide "required" indicator in new sidebarmediawiki/extensions/VisualEditormaster+30 -38
Align more/less buttonmediawiki/extensions/VisualEditormaster+4 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

ECohen_WMDE created this task.Sep 7 2021, 3:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2021, 3:05 PM
ECohen_WMDE set the point value for this task to 3.Sep 7 2021, 3:05 PM
ECohen_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.
ECohen_WMDE updated the task description. (Show Details)Sep 7 2021, 3:09 PM
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 13 2021, 11:51 AM
awight added a project: WMDE-TechWish-Sprint-2021-09-01.
lilients_WMDE claimed this task.Sep 13 2021, 11:54 AM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-01 board.
gerritbot added a comment.Sep 14 2021, 12:13 PM

Change 720970 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Align more/less button

https://gerrit.wikimedia.org/r/720970

gerritbot added a project: Patch-For-Review.Sep 14 2021, 12:13 PM
lilients_WMDE updated the task description. (Show Details)Sep 14 2021, 12:20 PM
gerritbot added a comment.Sep 14 2021, 12:59 PM

Change 720970 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Align more/less button

https://gerrit.wikimedia.org/r/720970

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 14 2021, 1:10 PM
lilients_WMDE updated the task description. (Show Details)Sep 14 2021, 1:23 PM
lilients_WMDE updated the task description. (Show Details)
gerritbot added a comment.Sep 14 2021, 2:15 PM

Change 720984 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Hide \"required\" indicator in new sidebar

https://gerrit.wikimedia.org/r/720984

gerritbot added a project: Patch-For-Review.Sep 14 2021, 2:15 PM
thiemowmde moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 14 2021, 2:15 PM
lilients_WMDE updated the task description. (Show Details)Sep 15 2021, 7:17 AM
awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 15 2021, 7:33 AM
thiemowmde moved this task from Demo to Review on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 15 2021, 7:39 AM
gerritbot added a comment.Sep 15 2021, 7:44 AM

Change 720984 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Hide \"required\" indicator in new sidebar

https://gerrit.wikimedia.org/r/720984

lilients_WMDE moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 15 2021, 7:50 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2021, 8:10 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-09-15.Sep 15 2021, 8:13 AM
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-09-15 board.
lilients_WMDE added a comment.Sep 28 2021, 7:56 AM

The more/less button is aligned with the right side of the input fields & the symbols to the right of the parameter names (i for deprecated) has a space between the name and the symbol:

Screenshot from 2021-09-28 09-55-05.png (598×1 px, 64 KB)

ECohen_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 28 2021, 8:21 AM
thiemowmde closed this task as Resolved.Sep 28 2021, 8:29 AM
thiemowmde added a parent task: T291907: More button still misplaced with odd combinations of feature flags.Sep 28 2021, 9:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL