The search box that is outputted in Minerva uses data defined in MinervaTemplate::getTemplateData() that duplicates data generated by SkinMustache
TODO
- Remove searchPageTitle from MinervaTemplate::getTemplateData(). Update template to use ['data-search-box']['page-title'] instead.
- Remove searchButton from MinervaTemplate::getTemplateData(). Update template to use ['data-search-box']['html-minerva-searchClass'] and msg-searchbutton instead.
- Remove wgScript from MinervaTemplate::getTemplateData(). Update template to use [data-search-box]form-action instead
- Remove the search template parameter (see note below)
- Remove placeholder from MinervaTemplate::getTemplateData()
Note about 'search' parameter
When visiting https://en.m.wikipedia.org/wiki/Foobar?search=foo the "Foo" string is shown in the input title. This is not consistent with desktop where none is shown and not helpful as focusing the search clears the string. This should thus be removed.
QA steps
- Visit any page on beta cluster
- Verify the logo (and/or site title) is present in the page.
- Type some characters into search, and hit enter. Confirm you are taken to the top search result.
- Type some characters into search, and click "search within pages". You should be taken to a list of search results
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T290525#7468155 |
| 2 | ❓ | T290525#7468155 |
| 3 | ✅ | T290525#7468155 |
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T290525#7475231 |
| 2 | ✅ | T290525#7475231 |
| 3 | ✅ | T290525#7475231 |
