Page MenuHomePhabricator
Create Task
Maniphest T290534

Number beside "Files uploaded" links to a blank log
Closed, ResolvedPublicBUG REPORT
Actions

Description

I have raised this issue on my primary talk page at the English Wikipedia User talk:CJDOS § Upload logs, and was instructed to make a report here at Phabricator.

List of steps to reproduce (step by step, including full links if applicable):

  • Go to my Xtools user statistics page at https://xtools.wmflabs.org/ec/en.wikipedia.org/CJDOS
  • In a column on the left hand side are the headings "Pages", followed by "Files".
  • Listed below the Files heading are my upload counts.
  • The number beside "Files uploaded (Commons)" links to a populated log.
  • The number beside "Files uploaded" (my Wikipedia uploads) links to a blank log.

What happens?:
The number next to "Files uploaded" (the files I've uploaded to Wikipedia) links to a blank log. This blank log contains the text: "Deleted files are not shown here but are included in the upload log." Clicking the upload log link reveals all of the files I have uploaded to Wikipedia, live and deleted.

What should have happened instead?:
I believe the first log (this one) should have displayed the files I have uploaded to Wikipedia. Instead, it is inexplicably a blank log—not even live files.

Related Objects

Event Timeline

CJDOS created this task.Sep 7 2021, 11:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2021, 11:35 PM
Enterprisey added a project: XTools.Sep 8 2021, 1:46 AM
MusikAnimal added a project: MediaWiki-File-management.Sep 8 2021, 7:01 AM
MusikAnimal moved this task from Backlog to Edit Counter on the XTools board.
MusikAnimal subscribed.

I believe XTools is counting only new uploads, both live and deleted, so it should link to https://en.wikipedia.org/wiki/Special:Log?type=upload&user=CJDOS&page=&wpdate=&tagfilter=&subtype=upload

The issue with Special:ListFiles seems to be a bug. I noticed the files you've uploaded have been replaced by newer images by other accounts, but even with the "Include old versions of files" checkbox ticked, it's a blank log. That is an issue separate from XTools that I think falls under MediaWiki-File-management.

This task is summarized as being about an issue with Special:ListFiles. The repro steps incidentally describe an unrelated minor bug with XTools.

Maintenance_bot added a project: Commons.Sep 8 2021, 7:46 AM
Dylsss removed projects: Commons, MediaWiki-File-management.Mar 14 2022, 2:14 PM
Dylsss subscribed.

Special:ListFiles is blank because the old versions are deleted (as non-free files).

CJDOS added a comment.Mar 14 2022, 5:19 PM
In T290534#7774122, @Dylsss wrote:

Special:ListFiles is blank because the old versions are deleted (as non-free files).

Thank you for the reply. If a bot reduces the size of a non-free image, the previous version is eventually deleted. I have one non-free file currently showing in the list, because I could only find a thumbnail of the image; as a non-free file, it is of an acceptable demonstration size, and so hasn't been replaced.

In this context, "Deleted files are not shown here but are included in the upload log" near the top of the page, makes sense.

Aklapper renamed this task from Upload logs to Number beside "Files uploaded" links to a blank log.Mar 14 2022, 5:26 PM
MusikAnimal mentioned this in rXT8d40b2713a5d: EditCounter: link to Special:Log for uploads.Mar 15 2022, 7:08 PM
MusikAnimal claimed this task.Mar 15 2022, 7:08 PM
MusikAnimal moved this task from Edit Counter to Pending deployment on the XTools board.

I think counting deleted uploads is the desired behaviour, and hence the fix is to simply link to Special:Log which represents both live and deleted. I have pushed a commit and will deploy this soon.

MusikAnimal closed this task as Resolved.Mar 16 2022, 6:13 PM
MusikAnimal moved this task from Pending deployment to Complete on the XTools board.

Deployed

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL