Page MenuHomePhabricator

Regression: new VE template sidebar "unsaved changes" broken
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Edit a page with VE visual mode, on the beta cluster.
  • Create a new template
  • Add some fields
  • Click the "<" back button

What happens?:

  • Changes are discarded with no warning.

What should have happened instead?:

  • Prompt to cancel "back".
  • Note that "X" close button has never implemented the unsaved changes prompt.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

  • Current development head.

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
OpenNone
ResolvedWMDE-Fisch
Resolvedawight
DeclinedNone
ResolvedNone
InvalidNone
Resolvedthiemowmde
Resolvedlilients_WMDE
InvalidNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedAndrew-WMDE
ResolvedNone
ResolvedNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedNone
Resolvedawight
ResolvedAndrew-WMDE
InvalidNone
Resolvedthiemowmde
ResolvedBUG REPORTWMDE-Fisch
ResolvedBUG REPORTthiemowmde
ResolvedBUG REPORTthiemowmde
ResolvedWMDE-Fisch
OpenBUG REPORTNone
ResolvedECohen_WMDE
OpenNone
OpenNone
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedBUG REPORTawight

Event Timeline

Change 719520 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Clean up post- OOUI fix

https://gerrit.wikimedia.org/r/719520

Change 719521 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Fix term in valuable data test

https://gerrit.wikimedia.org/r/719521

awight removed awight as the assignee of this task.Sep 8 2021, 1:48 PM
awight set the point value for this task to 1.
awight moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-01 board.

Change 719895 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add tests for .containsValuableData() methods

https://gerrit.wikimedia.org/r/719895

Change 719521 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix term in valuable data test

https://gerrit.wikimedia.org/r/719521

Change 719520 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Clean up post- OOUI fix

https://gerrit.wikimedia.org/r/719520

Change 719895 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add tests for .containsValuableData() methods

https://gerrit.wikimedia.org/r/719895

awight claimed this task.
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.