Maniphest T290573

Upgrade push notifications to nodejs 12
Closed, ResolvedPublic
Actions

Assigned To

vadim-kovalenko

Authored By

	Jgiannelos
	Sep 8 2021, 2:17 PM

Tags

Referenced Files

None

Subscribers

Description

Background information

Currently, the push-notifications service is using nodejs 10 image in production. After some research on phabricator tickets, it looks like we now have production images for nodejs-12 (bullseye based):

https://docker-registry.wikimedia.org/nodejs12-slim/tags/

What

Migrate mobileapps to nodejs12

How

Update the blubber file that generate the images and test the codebase
Update code as needed in case there are incompatibilities between nodejs 10 and nodejs 12

Open questions

...

Acceptance criteria

Documentation is updated
Service is benchmarked before deploying the image to production
The service is migrated to nodejs 12

Details

	Subject	Repo	Branch	Lines +/-
	Upgrade push notifications to nodejs 12	mediawiki/services/push-notifications	master	+4 K -3 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T290750 Migrate node-based services in production to node12
		Resolved		Jgiannelos	T290575 [EPIC] Upgrade PI node services to nodejs 12
		Resolved		vadim-kovalenko	T290573 Upgrade push notifications to nodejs 12

Event Timeline

Jgiannelos created this task.Sep 8 2021, 2:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2021, 2:17 PM

Jgiannelos added a parent task: T290575: [EPIC] Upgrade PI node services to nodejs 12.Sep 8 2021, 2:31 PM

Jgiannelos triaged this task as Medium priority.Sep 8 2021, 3:23 PM

vadim-kovalenko claimed this task.Sep 16 2021, 8:12 AM

vadim-kovalenko moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Sep 16 2021, 8:18 AM

vadim-kovalenko edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

vadim-kovalenko moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

vadim-kovalenko moved this task from Doing to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 22 2021, 1:26 PM

Change 720918 had a related patch set uploaded (by MSantos; author: Vadim Kovalenko):

[mediawiki/services/push-notifications@master] Upgrade push notifications to nodejs 12

https://gerrit.wikimedia.org/r/720918

gerritbot added a project: Patch-For-Review.Nov 17 2021, 6:51 PM

Change 720918 merged by jenkins-bot:

[mediawiki/services/push-notifications@master] Upgrade push notifications to nodejs 12

https://gerrit.wikimedia.org/r/720918

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2021, 8:10 PM

MSantos mentioned this in rMSPN5e7d387660ff: Upgrade push notifications to nodejs 12.Nov 17 2021, 9:31 PM

Jgiannelos moved this task from Blocked to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Dec 23 2021, 2:10 PM

Jgiannelos moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 7 2022, 12:50 PM

Jgiannelos closed this task as Resolved.Apr 7 2022, 1:15 PM