Page MenuHomePhabricator
Create Task
Maniphest T290709

Hidden radio buttons on history can still be selected with arrow keys on Firefox
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce:

  • Open a revision history page, e.g. that for w:Main Page, with Firefox.
  • Click on a visible radio button.
  • Use arrow keys to move the selection.

What happens?:

  • The selection goes away. If you click "Compare selected revisions", it navigates to a diff showing the same revision on both panes (which says "No difference", of course) or a diff showing revisions in the wrong order (the newer one on the left and the older one on the right in LTR).

What should have happened instead?:

  • Only visible buttons can be selected, and the arrow-key navigation loops once you hit a "dead end".

1.png (1×927 px, 111 KB)
2.png (1×927 px, 112 KB)
3.png (1×927 px, 113 KB)

Details

SubjectRepoBranchLines +/-
Disable hidden radio buttons on page history to fix behavior on Firefoxmediawiki/coremaster+18 -1
Customize query in gerrit

Event Timeline

Nardog created this task.Sep 10 2021, 6:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2021, 6:03 AM
Nardog renamed this task from Hidden radio buttons can be selected on Firefox to Hidden radio buttons on history can be selected on Firefox.Sep 10 2021, 6:03 AM
Nardog updated the task description. (Show Details)Sep 10 2021, 6:56 AM
Nardog updated the task description. (Show Details)Sep 10 2021, 7:16 AM
gerritbot added a comment.Sep 10 2021, 1:15 PM

Change 720301 had a related patch set uploaded (by Nardog; author: Nardog):

[mediawiki/core@master] Disable hidden radio buttons on page history to fix behavior on Firefox

https://gerrit.wikimedia.org/r/720301

gerritbot added a project: Patch-For-Review.Sep 10 2021, 1:15 PM
Nardog renamed this task from Hidden radio buttons on history can be selected on Firefox to Hidden radio buttons on history can still be selected with arrow keys on Firefox.Sep 11 2021, 2:36 PM
gerritbot added a comment.Sep 14 2021, 9:49 PM

Change 720301 merged by jenkins-bot:

[mediawiki/core@master] Disable hidden radio buttons on page history to fix behavior on Firefox

https://gerrit.wikimedia.org/r/720301

matmarex closed this task as Resolved.Sep 14 2021, 9:51 PM
matmarex assigned this task to Nardog.
matmarex subscribed.

I'm really surprised that no one reported this problem before (I looked for duplicates and did not find any). The code has been unchanged for years, and it affects not only recent Firefox, but seemingly every browser other than Chrome (I tested IE 11, as well as old Firefox 3.6 and Opera 12). Fascinating. Thanks for the patch!

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 14 2021, 10:10 PM
Nardog added a comment.EditedSep 15 2021, 3:52 PM

@matmarex Thank you for reviewing the patch. I hope it didn't break anything. I wonder if the conditional on line 61 (querying a.mw-changeslist-date) could be replaced with something more future-proof, e.g. giving a class to <li> with inaccessible revisions server-side.

matmarex added a comment.Sep 15 2021, 9:17 PM

Perhaps it could, but your solution seemed fine to me.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL