Page MenuHomePhabricator
Create Task
Maniphest T290751

Table of Contents community prototype testing
Closed, ResolvedPublic
Actions

Description

Background

Similar to what we did in T269155: Make community prototype production-ready, we would like to prepare a prototype for community testing that focuses on the new table of contents

Feature list

  • Table of Contents
  • Most recent iteration of the sticky header (for consistency)

Details

SubjectRepoBranchLines +/-
[POC] Prototype - Table of Contents in sidebar.mediawiki/skins/Vectormaster+21 K -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Sep 10 2021, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2021, 4:54 PM
ovasileva triaged this task as Medium priority.Sep 10 2021, 4:54 PM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
ovasileva moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.
ovasileva raised the priority of this task from Medium to High.Oct 6 2021, 2:33 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
LGoto assigned this task to Jdrewniak.Oct 7 2021, 5:17 PM
Jdrewniak moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 19 2021, 5:10 PM
gerritbot added a comment.Oct 25 2021, 5:53 PM

Change 734364 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [POC] Prototype - Table of Contents in sidebar.

https://gerrit.wikimedia.org/r/734364

gerritbot added a project: Patch-For-Review.Oct 25 2021, 5:53 PM
PatchDemoBot added a comment.Oct 25 2021, 5:56 PM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/4b80cc8580/w/

PatchDemoBot added a comment.Oct 25 2021, 6:54 PM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/02233882a6/w/

Jdrewniak reassigned this task from Jdrewniak to • alexhollender_WMF.Oct 28 2021, 5:23 PM
Jdrewniak moved this task from Doing to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• alexhollender_WMF added a comment.EditedOct 28 2021, 7:58 PM

@Jdrewniak to-do list:

  • ensure that the toc is highlighting the correct section (seems to work fine when scrolling, but when clicking a toc heading it sometimes gets confused: example)
  • add more space between toc and article
  • add a little more space between top-level toc items (5px)
  • close sidebar & show toc automatically when scrolled below bottom of sidebar
  • when clicking on a heading in the toc with sub-sections, expand & show sub-sections, and collapse any other open sections
  • add Introduction as first heading in toc, clicking it should take you to the top of the page
  • when sections open automatically the arrow should flip down
  • fix positioning of ⓘ button
  • replace ⓘ icon with gear/settings icon
  • make top-level heading stay bold when on a sub-section below it
  • lower z-index (currently it's on top of the search dropdown)

stretch goal:

  • load toc faster (if we can't do this maybe we could put a placeholder toc there?)
• alexhollender_WMF reassigned this task from • alexhollender_WMF to Jdrewniak.Nov 1 2021, 1:33 PM
• alexhollender_WMF moved this task from Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• alexhollender_WMF added a parent task: T273473: [Epic] Improve the table of contents.Nov 2 2021, 3:29 PM
• alexhollender_WMF mentioned this in T290174: [Mini-goal] Test table of contents with community & staff.Nov 2 2021, 3:33 PM
• alexhollender_WMF edited parent tasks, added: T290174: [Mini-goal] Test table of contents with community & staff; removed: T273473: [Epic] Improve the table of contents.
• alexhollender_WMF added a comment.Nov 15 2021, 4:11 PM

alright, final updates per the meeting @ovasileva @Jdrewniak and myself just had:

Clicking on a section heading

  • if the section has sub-sections, it should expand to show it's sub-section headings
  • if any other sections (with sub-sections) are expanded, collapse them

Clicking on a section sub-heading

  • if a section is expanded and I click on a sub-section heading, make sure that the section doesn't collapse (currently it does)

Clicking on Introduction

  • scroll all the way back up to the top of the page
PatchDemoBot added a comment.Nov 15 2021, 8:15 PM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/81c1e9ffb1/w/

PatchDemoBot added a comment.Nov 15 2021, 8:18 PM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/81c1e9ffb1/w/

PatchDemoBot added a comment.Nov 15 2021, 8:21 PM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d2973a74dd/w/

PatchDemoBot added a comment.Nov 16 2021, 3:28 AM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d2973a74dd/w/

PatchDemoBot added a comment.Nov 16 2021, 3:30 AM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/ed654c2127/w/

PatchDemoBot added a comment.Nov 16 2021, 3:58 AM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ed654c2127/w/

PatchDemoBot added a comment.Nov 16 2021, 4:01 AM

Test wiki created on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/8b17b5bfd1/w/

PatchDemoBot added a comment.Nov 16 2021, 4:24 AM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8b17b5bfd1/w/

PatchDemoBot added a comment.Nov 16 2021, 4:41 AM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/02233882a6/w/

PatchDemoBot added a comment.Nov 16 2021, 4:41 AM

Test wiki on Patch Demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/4b80cc8580/w/

• alexhollender_WMF added a comment.Nov 16 2021, 3:31 PM

@Jdrewniak I realized one other thing: currently the ToC assumes the sticky header will be present, and therefore has top: 72px. It would be great if that could be conditional, and if they sticky header isn't present it should have top: 20px.

• alexhollender_WMF added a comment.Nov 18 2021, 6:26 PM

@Jdrewniak sorry forgot to add a comment after our meeting yesterday:

  • the arrows should be independent from the section titles, so you can toggle them open & closed without navigating anywhere

(click to view GIF)

toc toggle.gif (552×450 px, 832 KB)

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 9 2021, 5:37 PM
ovasileva claimed this task.Dec 14 2021, 6:09 PM
ovasileva moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ovasileva closed this task as Resolved.Dec 15 2021, 1:39 PM

Prototype testing is now happening: https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Third_prototype_testing/Feedback

gerritbot added a comment.Feb 23 2022, 4:41 PM

Change 734364 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] [POC] Prototype - Table of Contents in sidebar.

Reason:

https://gerrit.wikimedia.org/r/734364

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2022, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL