Page MenuHomePhabricator

Add an image: edit summary and publish
Open, HighPublic

Description

Corresponding task from "add a link": T269657: Add a link: edit summary and publish


After the user presses the "Publish" button from the captions step in T290781, they advance to the edit summary screen.
Note: Final copy updated below - see relevant tab for corresponding QQQ in the copy spreadsheet

  • Overall
    • This is a similar experience to the same step in "add a link" (T269657).
    • It does not contain any free text field for an edit summary, or checkboxes for "watch this page" or "minor edit".
    • Just as it usually does, the header should contain a back arrow to close it on mobile. This leads back to the "captions" step, where the user's caption should still be in place in the caption box.
    • Just as it usually does, the header should say, Save your changes.
  • If the user accepted the image
    • The publish button should say, Publish just like it usually does.
    • Body
      • Header: Summary (same as add links)
      • Below the header is a gray line.
      • Next, on the left side should be the bolded filename with a small image icon. On the right of that row should be a checkmark.
      • Below that should be the image preview.
      • Below that should be the caption.
      • Last is where we put the publishing disclaimer which is unique to each wiki: By publishing changes, you agree to the...
    • The footer should have the standard Review your changes button. This should open up the visual diff review, just like it usually does.
    • After tapping the publish button, the changes should be published to the wiki according to the rules in T290785: Add an image: edit business rules.
    • The published edit summary should use the same logic as implemented on T284078: Add a link: change the edit summary, and be like, "Image suggestions feature: 1 image added." It should include the edit tag described in T293166: Add an image: edit tag.
    • The page should be automatically added to the user's watchlist (note that the mockups below include the feature described in T289547: Add a link: give users options for watchlist, which is not required for Iteration 1).
  • If the user rejected the image
    • The publish button should say, Submit.
    • Body
      • Header: Summary
      • Below the header is a gray line.
      • Next, on the left side should be the bolded filename with a small image icon. On the right of that row should be an "X". Note: there should be no "X", even though there is a checkmark for the accepted image. Filed here: T295795: Add an image: remove "X" from edit summary.
      • Below that (same as the caption text for an accepted image) should be the text: This image suggestion was rejected.
      • Last is where we put the publishing disclaimer which is unique to each wiki: "By publishing changes, you agree to the..."
    • The footer should not have a "Review your changes" button.
    • After tapping the submit button, nothing should be published to the wiki, and there should be no edit summary.
    • The page should not be automatically added to the user's watchlist.
  • No matter what the user has and has not chosen, a log entry gets created per T293169: Add an image: log entries.

Mockup as of 2021-10-12:

image.png (1×1 px, 429 KB)

Figma: https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=3018%3A9418

Event Timeline

MMiller_WMF renamed this task from Add an image: edit summary and publish (PLACEHOLDER) to Add an image: edit summary and publish.Oct 13 2021, 2:30 AM
MMiller_WMF removed MMiller_WMF as the assignee of this task.
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF edited subscribers, added: Sgs; removed: Mmiller0712.

With latest changes:

Acceptance summary

addImage_save_accept.gif (1×886 px, 3 MB)

Rejection summary

addImage_save_reject.gif (1×886 px, 1 MB)

Edit summary localized in the user's language (in the example, the user language is en & site language is cs)

Screen Shot 2021-10-22 at 3.09.52 PM.png (454×704 px, 55 KB)

Change 733085 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary

https://gerrit.wikimedia.org/r/733085

Change 733085 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary

https://gerrit.wikimedia.org/r/733085

Change 734335 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary followup

https://gerrit.wikimedia.org/r/734335

Change 734335 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: edit summary followup

https://gerrit.wikimedia.org/r/734335

Change 737784 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: update copy & QQQs for image inspector, rejection dialog, edit summary, caption UI

https://gerrit.wikimedia.org/r/737784

Change 738051 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Save dialog icon color

https://gerrit.wikimedia.org/r/738051

Change 738051 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Save dialog icon color

https://gerrit.wikimedia.org/r/738051

Change 737784 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: update copy & QQQs for image inspector, rejection dialog, edit summary, caption UI

https://gerrit.wikimedia.org/r/737784

@mewoph -- after looking at the current version, we realized we want to change the specification. You can see in the task description that I removed the requirement to have an "X" in the summary for the rejected image. I have filed this separately as T295795: Add an image: remove "X" from edit summary.