Page MenuHomePhabricator

Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler
Closed, ResolvedPublic

Description

\Hooks::run is deprecated. \MediaWiki\HookContainer\HookContainer::run() should be used instead

See T240307: Hook container with strong types and DI for context.

Create a service holding the hook container i.e. WikibaseClient.HookRunner and inject that instead.

see [T254558] for examples

Event Timeline

dang renamed this task from Fix deprecated \Hooks::run call in \Wikibase\Client\Changes\ChangeHandler to Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler.Sep 13 2021, 2:43 PM

Change 722642 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] [DNM][WIP]Fix deprecated Hooks::run() call in ChangeHandler

https://gerrit.wikimedia.org/r/722642

Change 722642 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix deprecated Hooks::run() call in ChangeHandler

https://gerrit.wikimedia.org/r/722642

Change 726918 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] [DNM][WIP]Create service to hold the hook container

https://gerrit.wikimedia.org/r/726918

Change 726918 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create service to hold the hook container

https://gerrit.wikimedia.org/r/726918