Page MenuHomePhabricator

Reply added in the wrong place in a DiscussionTools edit
Open, MediumPublic

Description

Reply added in the wrong place in a DiscussionTools edit: https://commons.wikimedia.org/?diff=588289777

Event Timeline

@matmarex, do you have a sense for what's causing this issue and subsequently, how widespread it could be?

...I ask the above looking at the diff and page's source and thinking, "Hmm, it's not immediately obvious that this page is using non-standard syntax/conventions...I wonder whether something recently changed about the Reply Tool that could've caused it to mishandle, what appears to me, to be a relatively straightforward use case."

Arlolra triaged this task as Medium priority.Sep 23 2021, 12:36 AM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra subscribed.

So https://commons.wikimedia.org/w/index.php?title=Commons:Deletion_requests/File:Power_Plant_Mall,_Makati_City.jpg&oldid=578127262 has the following code,

</span>]]) 14:48, 2 August 2021 (UTC)
<noinclude>[[Category:Philippine FOP cases/pending]]</noinclude> {{unsigned2|14:50, 2 August 2021|Caehlla2357}}

which Parsoid renders as thus,
https://commons.wikimedia.org/api/rest_v1/page/html/Commons:Deletion_requests%2FFile:Power_Plant_Mall,_Makati_City.jpg/578127262

Presumably, the problem is that normally the token stream patcher will suppress the newlines before a category (since the legacy parser does that),
https://github.com/wikimedia/parsoid/blob/master/src/Wt2Html/TT/TokenStreamPatcher.php#L260-L298

but because the category is in noinclude tags, it doesn't do it across that boundary so this gets rendered as preformatted. VE edits in this area on that page get dirtied too.