Page MenuHomePhabricator
Create Task
Maniphest T290953

Results page - confirmation of review decision submission
Closed, ResolvedPublic13 Estimated Story Points
Actions

Assigned To
ItamarWMDE
Authored By
Lydia_Pintscher
Sep 14 2021, 9:54 AM
Tags
Referenced Files
F34694354: Screenshot 2021-10-18 at 16.44.41.png
Oct 18 2021, 2:47 PM
F34671581: Screenshot 2021-10-04 at 12.19.01.png
Oct 4 2021, 10:21 AM
F34660038: Screenshot 2021-09-28 at 09.59.09.png
Sep 28 2021, 7:59 AM
F34621848: Screenshot 2021-08-27 at 12.25.18.png
Sep 14 2021, 9:54 AM
F34621856: Screenshot 2021-08-27 at 12.27.33.png
Sep 14 2021, 9:54 AM
Subscribers
Aklapper
ItamarWMDE
Lydia_Pintscher
Mattia_Capozzi_WMDE
Sarai-WMDE

Description

As a mismatch reviewer
I want to get a confirmation for my review decision submission
in order to know that my submission has been processed properly

As a mismatch store admin
I want mismatch reviewers to get a reminder that indicating their decision in the Mismatch Finder is not enough and that they also need to edit Wikidata where appropriate
in order to avoid mismatches being marked as reviewed without errors being fixed in Wikidata

Screenshots/mockups:
Link to Workflow on Figma.
Link to Dialog Component on Figma

Component Notes:

  • This task does not require us to implement neither the loading state, the simple variant or the responsive variant of the dialog.
  • The component specs refer to tokens that are not yet created - marked as "TBC". In those cases we may use "hardcoded" css values.
  • The max height of an implemented dialog should be around 450px however, please consult with @Mattia_Capozzi_WMDE when implementing.

Screenshot 2021-10-18 at 16.44.41.png (473×539 px, 54 KB)
Dialog appears after clicking the "Submit Status" button. Here below, there is the content of the dialog:

Now that the changes are submitted successfully, remember:

• If the mismatch is on Wikidata, please use the link to the statement and edit it there to correct the mismatch.

• If the mismatch is on the external source, please inform the data source's maintainers of the error or correct the mismatch yourself, if possible.

• If the mismatch is on both sides, please use the link to the Wikidata statement to correct it and/or inform the data source’s maintainers of the error.

BDD
GIVEN a mismatch results page
AND a review decision being selected
WHEN clicking "submit status"
THEN the page indicates the results are being stored (through a loading animation Not part of this ticket see [Ticket TBA]])
AND THEN I can see a dialog informing me about the submission of my review decisions

Acceptance criteria:

  • reviewers can see a dialog informing them about the submission and next steps after results have been saved to the store
  • dialog can be dismissed
  • checkbox exists to not show the dialog again for future submissions of review decisions
  • the ticket that covers the responsiveness of the dialog is linked to this one :D

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedItamarWMDET290953 Results page - confirmation of review decision submission
 ResolvedLydia_PintscherT290822 Results page - submit review decisions
 ResolvedItamarWMDET289557 Results page - indicate review decisions
 ResolvedLydia_PintscherT285849 Record the reviewer decision and associated metadata for a specific mismatch
 ResolvedSilvan_WMDET289132 Update mismatches concept
 Resolvedguergana.tzatchkovaT289133 Create an "edit" endpoint to take a partial json with the 'review_status' attribute changed
 ResolvedSilvan_WMDET289134 Log the review decision with Laravel's logging framework
 ResolvedLydia_PintscherT289556 Results page - first view of mismatches
 ResolvedItamarWMDET289843 create simple table component with default states
 Resolvedguergana.tzatchkovaT291064 Pass json response from backend into the Results Page component
 ResolvedSilvan_WMDET294303 Do not pass results prop into Results page when no mismatches have been found
 ResolvedItamarWMDET291066 Expand Wikibase API client service to retrieve labels from Wikidata
InvalidItamarWMDET291563 Use `WikibaseClientAPI->getLabels` to retrieve labels for items and properties in the `results` web route
 ResolvedItamarWMDET291074 Wikit: Move Table Component to Wikit
 Resolvedguergana.tzatchkovaT291077 WiKit: Create a story file for the Table component
 ResolvedItamarWMDET291078 WiKit: Make a pre-release that includes the Table component
 ResolvedItamarWMDET291079 Replace table component in Mismatch finder with table from Wikit
 ResolvedSilvan_WMDET293730 Show only "pending" mismatches in the results page
 Resolvedguergana.tzatchkovaT294523 Results Page - "Value on external source" column should link to the external_url
 ResolvedSarai-WMDET290823 Create complex variant of Dialog component
 ResolvedSarai-WMDET294849 Port Dialog Component to WiKit
 ResolvedSilvan_WMDET295874 Copy Dialog Component Code to WiKit
 Resolvedguergana.tzatchkovaT295875 Add Storybook Documentation for Dialog Component
 ResolvedItamarWMDET297093 Fix Display of Dialog in storybook
 ResolvedItamarWMDET295877 WiKit pre-release with Dialog component
 Resolvedguergana.tzatchkovaT292054 Submit mismatches from Results page
 ResolvedSilvan_WMDET292055 Handle errors and display a Wikit message in the same way as done on the Home page
 Resolvedguergana.tzatchkovaT292050 Create a web endpoint to update a batch of mismatches
 ResolvedNoneT292058 Combine endpoint for batch-updating mismatches with frontend form submission
 DeclinedNoneT289844 loading state of simple table component

Event Timeline

Lydia_Pintscher created this task.Sep 14 2021, 9:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2021, 9:54 AM
Lydia_Pintscher triaged this task as High priority.Sep 14 2021, 9:58 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added a subtask: T290822: Results page - submit review decisions.
Lydia_Pintscher moved this task from Backlog to Ready for estimating on the Mismatch Finder board.
Mattia_Capozzi_WMDE mentioned this in T290822: Results page - submit review decisions.Sep 21 2021, 3:37 PM
Mattia_Capozzi_WMDE updated the task description. (Show Details)Sep 21 2021, 3:46 PM
Mattia_Capozzi_WMDE updated the task description. (Show Details)
Mattia_Capozzi_WMDE updated the task description. (Show Details)Sep 28 2021, 7:59 AM
Lydia_Pintscher added a subtask: T289844: loading state of simple table component.Sep 28 2021, 2:27 PM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher renamed this task from Results page - confirm review decisions to Results page - confirmation of review decision submission.Sep 29 2021, 2:48 PM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher updated the task description. (Show Details)
Sarai-WMDE closed subtask T289844: loading state of simple table component as Declined.Sep 30 2021, 2:03 PM
Mattia_Capozzi_WMDE updated the task description. (Show Details)Oct 4 2021, 10:21 AM
karapayneWMDE set the point value for this task to 13.Oct 18 2021, 1:18 PM
karapayneWMDE moved this task from Ready for estimating to Mismatch Finder - sprint 9 on the Mismatch Finder board.
karapayneWMDE edited projects, added Mismatch Finder (Mismatch Finder - sprint 9); removed Mismatch Finder.
karapayneWMDE mentioned this in T290849: Results page - Displaying upload description of the uploaded mismatches (and full description dialog).Oct 18 2021, 1:25 PM
karapayneWMDE updated the task description. (Show Details)Oct 18 2021, 1:38 PM
Mattia_Capozzi_WMDE updated the task description. (Show Details)Oct 18 2021, 2:47 PM
Lydia_Pintscher closed subtask T290822: Results page - submit review decisions as Resolved.Oct 18 2021, 3:41 PM
ItamarWMDE added a subscriber: ItamarWMDE.EditedOct 19 2021, 8:24 AM

Task Breakdown Notes:

  • Regarding the workflow:
    1. User clicks submit
    2. Page submits changes
    3. Response is received from server
    4. Dialog appears (unless user opted out)
  • Potential plan of action:
    1. Create Dialog Component (Tested by JS Unit tests)
    2. Implement dialog in Context (Tested by Browser tests),
    3. Persist decision regarding dialog display (checkbox) on the clientside (Tested by Browser tests)
ItamarWMDE updated the task description. (Show Details)Oct 19 2021, 8:26 AM
ItamarWMDE updated the task description. (Show Details)Oct 19 2021, 8:41 AM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE added a subscriber: Mattia_Capozzi_WMDE.Oct 19 2021, 8:46 AM

@Mattia_Capozzi_WMDE Can you please provide the copy for the dialog in the ticket description?

ItamarWMDE updated the task description. (Show Details)Oct 19 2021, 9:03 AM
ItamarWMDE updated the task description. (Show Details)Oct 19 2021, 9:11 AM
Sarai-WMDE added a subscriber: Sarai-WMDE.Oct 19 2021, 2:29 PM

A first draft of the complex dialog component tokens is available in #494, in case the use of these is preferred to hard-coded values. Review pending.

ItamarWMDE claimed this task.Oct 19 2021, 2:47 PM
ItamarWMDE moved this task from To Do to Doing on the Mismatch Finder (Mismatch Finder - sprint 9) board.
ItamarWMDE added a comment.EditedOct 21 2021, 9:02 AM

Pull Requests:

  • Dialog Component: PR #160
  • Add Confirmation Dialog to results page: PR #178
  • Persist decision regarding dialog display: PR #181
Mattia_Capozzi_WMDE updated the task description. (Show Details)Oct 28 2021, 3:16 PM
ItamarWMDE moved this task from Doing to Peer Review on the Mismatch Finder (Mismatch Finder - sprint 9) board.Oct 29 2021, 4:57 PM
karapayneWMDE moved this task from Mismatch Finder - sprint 9 to Mismatch Finder - sprint 10 on the Mismatch Finder board.Nov 2 2021, 2:52 PM
karapayneWMDE edited projects, added Mismatch Finder (Mismatch Finder - sprint 10); removed Mismatch Finder (Mismatch Finder - sprint 9).
ItamarWMDE moved this task from To Do to Test (Verification) on the Mismatch Finder (Mismatch Finder - sprint 10) board.Nov 3 2021, 8:55 AM
Mattia_Capozzi_WMDE closed this task as Resolved.Nov 9 2021, 10:45 AM

Looking great!

ItamarWMDE moved this task from Test (Verification) to Done on the Mismatch Finder (Mismatch Finder - sprint 10) board.Nov 11 2021, 9:59 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL