Page MenuHomePhabricator

Hard deprecate PageContentSave hook
Closed, ResolvedPublic

Description

The hook seem to be only used in one deployed extension, TemplateData. Hard-deprecating it and back porting the change to MW 1.37 will allow us to entirely cut the dependency from PageUpdater to User in 1.38.

Event Timeline

tchin changed the task status from Open to In Progress.Sep 15 2021, 5:46 PM

Change 721616 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/TemplateData@master] Replace deprecated onPageContentSave hook

https://gerrit.wikimedia.org/r/721616

Change 721872 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/Translate@master] Replace deprecated PageContentSave hook

https://gerrit.wikimedia.org/r/721872

Change 721872 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated PageContentSave hook

https://gerrit.wikimedia.org/r/721872

Change 721616 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Replace deprecated onPageContentSave hook

https://gerrit.wikimedia.org/r/721616

Seems ready to be hard-deprecated. Let's try to create a patch with 1.37 as a target, and if folks don't let us, change it to be 1.38

Aklapper changed the task status from In Progress to Open.Mar 22 2025, 7:23 AM

Resetting task status from "In Progress" to "Open" as this task has been "in progress" for more than two years.

Change #1130614 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Hard-deprecate the PageContentSave hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/1130614

Change #1130614 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate the PageContentSave hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/1130614

Aklapper added a subscriber: tchin.

@tchin: Removing task assignee as this open task has been assigned for more than two years - See the email sent on 2025-05-22.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!