Page MenuHomePhabricator

Hard deprecate PageContentSave hook
Open, In Progress, Needs TriagePublic

Description

The hook seem to be only used in one deployed extension, TemplateData. Hard-deprecating it and back porting the change to MW 1.37 will allow us to entirely cut the dependency from PageUpdater to User in 1.38.

Event Timeline

tchin changed the task status from Open to In Progress.Sep 15 2021, 5:46 PM

Change 721616 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/TemplateData@master] Replace deprecated onPageContentSave hook

https://gerrit.wikimedia.org/r/721616

Change 721872 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/Translate@master] Replace deprecated PageContentSave hook

https://gerrit.wikimedia.org/r/721872

Change 721872 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated PageContentSave hook

https://gerrit.wikimedia.org/r/721872

Change 721616 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Replace deprecated onPageContentSave hook

https://gerrit.wikimedia.org/r/721616

Seems ready to be hard-deprecated. Let's try to create a patch with 1.37 as a target, and if folks don't let us, change it to be 1.38