Page MenuHomePhabricator

A function call used as an argument should validate its return type against the expected type of the argument
Closed, ResolvedPublic

Description

If a function call is made - either for an implementation or as a one-off function call - validation should check that arguments that are function calls are using a function whose return type is compatible with the type of the given argument.

E.g.

concatenate("ab", reverse("ab"))

when validating this function call, expecting a string for the second argument, we should check that reverse has the return type string, or else raise a validation error

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
StalledNone
Resolvedcmassaro
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
Resolvedcmassaro
OpenNone
ResolvedNone
ResolvedNone
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
Resolvedgengh
ResolvedNone
DeclinedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedBUG REPORTJdforrester-WMF
ResolvedSimoneThisDot
Resolvedgengh
Resolvedgengh
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedDVrandecic
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedNone
ResolvedNone
Resolvedcmassaro
ResolvedDVrandecic
ResolvedLindsaykwardell
Resolvedarthurlorenzi
ResolvedNone
InvalidNone
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedgengh
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedDVrandecic
Resolvedcmassaro
Resolvedarthurlorenzi
ResolvedAdesojiThisDot

Event Timeline

Change 722980 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Add validation for generic types.

https://gerrit.wikimedia.org/r/722980

Change 722980 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add validation for generic types.

https://gerrit.wikimedia.org/r/722980

Change 724485 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724485

Change 724486 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724486

Change 724144 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724144

Change 724485 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724485

Change 724144 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724144

Change 724486 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724486