Page MenuHomePhabricator
Create Task
Maniphest T291033

A function call used as an argument should validate its return type against the expected type of the argument
Closed, ResolvedPublic
Actions

Description

If a function call is made - either for an implementation or as a one-off function call - validation should check that arguments that are function calls are using a function whose return type is compatible with the type of the given argument.

E.g.

concatenate("ab", reverse("ab"))

when validating this function call, expecting a string for the second argument, we should check that reverse has the return type string, or else raise a validation error

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiLambdamaster+1 -1Update function-schemata sub-module to HEAD (5d37c64)
mediawiki/services/function-evaluatormaster+1 -1Update function-schemata sub-module to HEAD (5d37c64)
mediawiki/services/function-orchestratormaster+1 -1Update function-schemata sub-module to HEAD (5d37c64)
mediawiki/services/function-schematamaster+201 -76Add validation for generic types.
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedcmassaroT290898 Implement (De)Serialization for Generic/Compound Types
 OpenNoneT287608 Reconsider dropping Nothing and Unit in favor of Maybe
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedNoneT291033 A function call used as an argument should validate its return type against the expected type of the argument
 DeclinedNoneT291036 Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type
 ResolvedSimoneThisDotT291041 Instances of a generic type are displayed correctly
 ResolvedSimoneThisDotT291042 Instances of generic types can be edited
 ResolvedcmassaroT291044 Instances of generic types are being validated
 ResolvedcmassaroT285260 Orchestrator Top-Level Validation Should Check Z1K1
 ResolvedSimoneThisDotT297244 Let front-end users create and edit instances of any generic type
 ResolvedSimoneThisDotT291043 Instances of generic typed lists can be created
 ResolvedcmassaroT266241 Normalizer and canonicalizer should deal with local and global keys
 ResolvedcmassaroT289681 Composition creating a type doesn't evaluate
 ResolvedBUG REPORTJdforrester-WMFT292890 Trying to create a Z14 throws "Cannot read properties of undefined (reading 'filter')" in Vue code
 ResolvedSimoneThisDotT295470 Change the type search API to allow users to search for functions returning a type in addition to instances of that type
 ResolvedgenghT262089 Store type identity output in wikilambda_zobject_labels table
ResolvedgenghT297925 Change object search API to optionally include functions' return types as the 'type' filter
 ResolvedcmassaroT286975 Make it possible to define the Typed List function fully
 ResolvedcmassaroT287102 Resolve Z18s Wherever They Occur
 ResolvedJdforrester-WMFT291049 Function that takes a type and returns a type can be evaluated
 ResolvedDVrandecicT291050 Functions that take a type and return a type can be implemented
 ResolvedDVrandecicT291051 Functions that take a type and return a type can be defined
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedJdforrester-WMFT293831 WikiLambda documentation should explain how to get composer dependencies installed, lest users have missing ISchemaLoader fatals
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedarthurlorenziT290346 Function model: Change the signature of validators from Type -> List to Type -> Type (pass-through)
 ResolvedAdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object

Event Timeline

DVrandecic created this task.Sep 15 2021, 1:22 AM
DVrandecic added a subtask: T291036: Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type.Sep 15 2021, 1:53 AM
Jdforrester-WMF removed a project: Epic.Sep 15 2021, 7:58 PM
Jdforrester-WMF added a subtask: T277000: Validate a Z7/Function call in the wiki.Sep 15 2021, 9:43 PM
Jdforrester-WMF removed a subtask: T277000: Validate a Z7/Function call in the wiki.
Jdforrester-WMF added a parent task: T277000: Validate a Z7/Function call in the wiki.
gerritbot added a comment.Sep 28 2021, 5:32 PM

Change 722980 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Add validation for generic types.

https://gerrit.wikimedia.org/r/722980

gerritbot added a project: Patch-For-Review.Sep 28 2021, 5:32 PM
gerritbot added a comment.Sep 28 2021, 5:35 PM

Change 722980 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add validation for generic types.

https://gerrit.wikimedia.org/r/722980

Jdforrester-WMF mentioned this in rMSFSa676c1dbf46a: Add validation for generic types..Sep 28 2021, 5:35 PM
gerritbot added a comment.Sep 28 2021, 5:57 PM

Change 724485 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724485

gerritbot added a comment.Sep 28 2021, 5:57 PM

Change 724486 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724486

gerritbot added a comment.Sep 28 2021, 5:57 PM

Change 724144 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724144

gerritbot added a comment.Sep 29 2021, 12:09 AM

Change 724485 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724485

Jdforrester-WMF mentioned this in rMSFO39a359a67072: Update function-schemata sub-module to HEAD (5d37c64).Sep 29 2021, 12:09 AM
gerritbot added a comment.Sep 29 2021, 7:35 PM

Change 724144 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724144

Jdforrester-WMF mentioned this in rMSFE356f768122e3: Update function-schemata sub-module to HEAD (5d37c64).Sep 29 2021, 7:36 PM
gerritbot added a comment.Sep 29 2021, 7:36 PM

Change 724486 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5d37c64)

https://gerrit.wikimedia.org/r/724486

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2021, 8:10 PM
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 1 2022, 6:58 PM
Jdforrester-WMF closed subtask T291036: Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type as Declined.Mar 2 2022, 10:07 PM
DVrandecic closed this task as Resolved.Mar 8 2022, 5:25 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL