Wrong focus when adding a new template in mobile view
Closed, DeclinedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	lilients_WMDE
	Sep 15 2021, 9:41 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

open a multi-part template in mobile view
click the new template button

What happens?:
The focus does goes to the first element at the right.

Peek 2021-09-15 11-19.gif (827×1 px, 293 KB)

What should have happened instead?:
The focus should got to the template search (like it does in desktop view).

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc: feature flag $wgVisualEditorTransclusionDialogNewSidebar enabled

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		thiemowmde	T289043 [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane
Resolved		thiemowmde	T290975 Synchronize scroll and focus when template dialog is in narrow-screen mode
Declined	BUG REPORT	None	T291067 Wrong focus when adding a new template in mobile view

Event Timeline

lilients_WMDE created this task.Sep 15 2021, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2021, 9:41 AM

I can confirm this. For some reason it's only on mobile. Let's have a closer look at this after we resolved T289043 and possibly T290975.

awight added subtasks: T290975: Synchronize scroll and focus when template dialog is in narrow-screen mode, T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.Sep 15 2021, 12:11 PM

awight set the point value for this task to 3.Sep 15 2021, 1:13 PM

Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Sep 15 2021, 1:54 PM

lilients_WMDE added a project: WMDE-TechWish-Sprint-2021-09-15.Sep 15 2021, 1:55 PM

Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 15 2021, 1:57 PM

In T291080#7358312, @Andrew-WMDE wrote:

It looks like the reason we don't have an autofocus is due to a change introduced in T141852. The additional !OO.ui.isMobile() condition in BookletLayout.js$212 prevents ve.ui.MWParameterPage from receiving the focus when selected from the sidebar.

This is the same issue just with ve.ui.MWParameterPlaceholderPage instead of ve.ui.MWParameterPage.
Our solution needs to take into account all pages inheriting from OO.ui.PageLayout.