| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T291086 Polish Dispatching Jobs so they're ready for testwikidata | |||
| Resolved | Michael | T291087 Don't repeatedly dispatch old changes | |||
| Resolved | Ladsgroup | T291117 Make sure RC injection jobs don't inject duplicate entries | |||
| Open | None | T291118 Deduplicate based on entity id | |||
| Resolved | Michael | T291119 Make sure $changeLookup->loadByEntityId() reads from master | |||
| Resolved | Ladsgroup | T291121 Use constants for accessing Change fields | |||
| Resolved | Ladsgroup | T291125 Make sure new access patterns of wb_changes table have proper indexes in place |
Event Timeline
Comment Actions
Yup, it's not ready. Needs an index:
wikiadmin@10.64.48.173(wikidatawiki)> show index from wb_changes
-> ;
+------------+------------+-------------------------------+--------------+--------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+------------+------------+-------------------------------+--------------+--------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| wb_changes | 0 | PRIMARY | 1 | change_id | A | 894959 | NULL | NULL | | BTREE | | |
| wb_changes | 1 | wb_changes_change_time | 1 | change_time | A | 894959 | NULL | NULL | | BTREE | | |
| wb_changes | 1 | wb_changes_change_revision_id | 1 | change_revision_id | A | 894959 | NULL | NULL | | BTREE | | |
+------------+------------+-------------------------------+--------------+--------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
3 rows in set (0.000 sec)we possibly can drop an index on wb_changes_change_revision_id later. I don't know what's its point.
Comment Actions
@Marostegui hi, is it possible to check if index wb_changes_change_revision_id on wb_changes is used in wikidatawiki?
Comment Actions
Looks so on the majority of the hosts!
root@cumin1001:/home/marostegui# ./section s8 | grep eqiad | egrep -v "dbstore|clouddb|db1154|db1155" | while read host port; do echo "$host:$port"; mysql.py -h$host:$port sys -e "select * from schema_unused_indexes where object_name like 'wb_changes';";done db1178.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1177.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1172.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1171.eqiad.wmnet:3318 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1167.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1126.eqiad.wmnet:3306 db1116.eqiad.wmnet:3318 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1114.eqiad.wmnet:3306 db1111.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1109.eqiad.wmnet:3306 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1104.eqiad.wmnet:3306 db1101.eqiad.wmnet:3318 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id db1099.eqiad.wmnet:3318 object_schema object_name index_name wikidatawiki wb_changes wb_changes_change_revision_id root@cumin1001:/home/marostegui#
db1104 = master
db1126 = main traffic
db1114 = api (not sure why it gets used there)
Comment Actions
Created T292548: [C-DIS][SW] Drop index on change_revision_id in wb_changes table to follow-up on the index and now closing this because we not only already have fully deployed to testwikidata, but also fully to production.