Page MenuHomePhabricator
Create Task
Maniphest T291088

updateMenteeData.php fatals for testwiki
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Today, I discovered that this happens with updateMenteeData.php at testwiki:

[urbanecm@mwmaint1002 /srv/mediawiki/php]$ mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=testwiki
InvalidArgumentException from line 2690 of /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php: Wikimedia\Rdbms\Database::makeList: empty input for field actor_rev_user.actor_user
#0 /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php(2071): Wikimedia\Rdbms\Database->makeList(Array, 1)
#1 /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php(2010): Wikimedia\Rdbms\Database->selectSQLText(Array, Array, Array, 'GrowthExperimen...', Array, Array)
#2 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(159): Wikimedia\Rdbms\Database->select(Array, Array, Array, 'GrowthExperimen...', Array, Array)
#3 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(175): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getLastEditTimestampForUsers(Array)
#4 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(136): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->filterMenteesByLastEdit(Array)
#5 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(197): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFilteredMenteesForMentor(Object(User))
#6 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/maintenance/updateMenteeData.php(106): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFormattedDataForMentor(Object(User))
#7 /srv/mediawiki/php-1.37.0-wmf.23/maintenance/doMaintenance.php(108): GrowthExperiments\Maintenance\UpdateMenteeData->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/maintenance/updateMenteeData.php(200): require_once('/srv/mediawiki/...')
#9 /srv/mediawiki/multiversion/MWScript.php(116): require_once('/srv/mediawiki/...')
#10 {main}
[urbanecm@mwmaint1002 /srv/mediawiki/php]$

I'm not sure why. Might be related to some user not having any mentees?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
UncachedMenteeOverviewDataProvider: Do not fatal with zero menteesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.23+4 -0
UncachedMenteeOverviewDataProvider: Do not fatal with zero menteesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.21+4 -0
UncachedMenteeOverviewDataProvider: Do not fatal with zero menteesmediawiki/extensions/GrowthExperimentsmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Sep 15 2021, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2021, 3:12 PM
Urbanecm_WMF triaged this task as High priority.Sep 15 2021, 3:12 PM
Urbanecm_WMF added a comment.Sep 15 2021, 3:19 PM

It looks so:

[urbanecm@mwmaint1002 /srv/mediawiki/php]$ mwscript shell.php testwiki
Psy Shell v0.10.5 (PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf1 — cli) by Justin Hileman
>>> $mentors = \MediaWiki\MediaWikiServices::getInstance()->get('GrowthExperimentsMentorManager')->getMentors()
=> [
     "Aseleste",
     "Geraki",
     "MMiller (WMF)",
     "Martin Urbanec (WMF)",
     "NMW03",
     "OTichonova (WMF)",
     "RHo (WMF)",
     "Suffusion of Yellow",
     "Sungodtemple",
     "Tgr (WMF)",
     "Trizek (WMF)",
     "ValeJappo",
     "Wargo",
     "Yahya",
     "Zilant17",
     "Xaosflux",
   ]
>>> $store = \MediaWiki\MediaWikiServices::getInstance()->get('GrowthExperimentsMentorStore')
=> GrowthExperiments\Mentorship\Store\MultiWriteMentorStore {#5812}
>>> foreach($mentors as $mentorName) {
... $mentor = User::newFromName($mentorName);
... $mentees = $store->getMenteesByMentor($mentor);
... if ($mentees == []) {
... echo("$mentorName has zero mentees");
... }
...
... }
Xaosflux has zero mentees⏎
>>> ^D
Exit:  Ctrl+D
[urbanecm@mwmaint1002 /srv/mediawiki/php]$

Temporarily workarounded by: 17:17, 15 September 2021 Martin Urbanec (WMF) talk contribs block set Xaosflux as the mentor of Martin Urbanec (WMF) (previous mentor Martin Urbanec) (to workaround T291088), but should still be properly fixed.

gerritbot added a comment.Sep 15 2021, 3:27 PM

Change 721338 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721338

gerritbot added a project: Patch-For-Review.Sep 15 2021, 3:27 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 15 2021, 3:27 PM
• thcipriani changed the subtype of this task from "Task" to "Production Error".Sep 15 2021, 6:49 PM
• thcipriani added a project: Wikimedia-production-error.
• thcipriani moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 16 2021, 4:21 AM
gerritbot added a comment.Sep 16 2021, 4:35 AM

Change 721338 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721338

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 5:10 AM
gerritbot added a comment.Sep 16 2021, 11:04 AM

Change 721318 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.23] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721318

gerritbot added a project: Patch-For-Review.Sep 16 2021, 11:04 AM

Change 721319 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.21] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721319

gerritbot added a comment.Sep 16 2021, 11:28 AM

Change 721319 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.21] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721319

gerritbot added a comment.Sep 16 2021, 11:30 AM

Change 721318 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.23] UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees

https://gerrit.wikimedia.org/r/721318

Urbanecm_WMF closed this task as Resolved.Sep 16 2021, 11:48 AM

Boldly resolving:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=testwiki
InvalidArgumentException from line 2690 of /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php: Wikimedia\Rdbms\Database::makeList: empty input for field actor_rev_user.actor_user
#0 /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php(2071): Wikimedia\Rdbms\Database->makeList(Array, 1)
#1 /srv/mediawiki/php-1.37.0-wmf.23/includes/libs/rdbms/database/Database.php(2010): Wikimedia\Rdbms\Database->selectSQLText(Array, Array, Array, 'GrowthExperimen...', Array, Array)
#2 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(159): Wikimedia\Rdbms\Database->select(Array, Array, Array, 'GrowthExperimen...', Array, Array)
#3 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(175): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getLastEditTimestampForUsers(Array)
#4 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(136): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->filterMenteesByLastEdit(Array)
#5 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(197): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFilteredMenteesForMentor(Object(User))
#6 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/maintenance/updateMenteeData.php(106): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFormattedDataForMentor(Object(User))
#7 /srv/mediawiki/php-1.37.0-wmf.23/maintenance/doMaintenance.php(108): GrowthExperiments\Maintenance\UpdateMenteeData->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.23/extensions/GrowthExperiments/maintenance/updateMenteeData.php(200): require_once('/srv/mediawiki/...')
#9 /srv/mediawiki/multiversion/MWScript.php(116): require_once('/srv/mediawiki/...')
#10 {main}
[urbanecm@mwmaint1002 ~]$ scap pull
11:47:30 Copying from deploy1002.eqiad.wmnet to mwmaint1002.eqiad.wmnet
11:47:30 Started rsync common
11:47:33 Finished rsync common (duration: 00m 02s)
11:47:33 Started scap-cdb-rebuild
11:47:33 Finished scap-cdb-rebuild (duration: 00m 00s)
11:47:33 Checking if php-fpm restart needed
[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=testwiki
Done. Took 7 seconds.
[urbanecm@mwmaint1002 ~]$

appears it did its job.

Stashbot added a comment.Sep 16 2021, 11:49 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-16T11:49:33Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.23/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php: rEGRE9e0f6f84240b: UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees (T291088) (duration: 01m 04s)

Stashbot added a comment.Sep 16 2021, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-16T11:51:46Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.21/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php: rEGRE529f86c5a998: UncachedMenteeOverviewDataProvider: Do not fatal with zero mentees (T291088) (duration: 01m 04s)

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Sep 16 2021, 12:00 PM
Urbanecm_WMF added a project: GrowthExperiments-Mentorship.Jul 4 2024, 5:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:40 PM
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jul 9 2024, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits