Page MenuHomePhabricator

"Say hi to your new mentor!" message partially truncated
Open, MediumPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Receive a notification that someone is your new mentor (I don’t know what the mentor has to do to make this happen)
  • Open the notification

What happens?:
The text visually cuts off in a mildly funny position: “Say hi to your new men”. (This might depend on installed fonts etc.)

Screenshot 2021-09-15 at 19-16-38 User talk Martin Urbanec (WMF) - Test Wikipedia.png (100×500 px, 9 KB)

What should have happened instead?:
The text should display completely: “Say hi to your new mentor!” (copied from dev tools)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
1.37.0-wmf.23 (c90ba33) on test.wikipedia.org; Mozilla Firefox Developer Edition 93.0b4

This seems to be due to the following CSS rule:

.mw-echo-ui-notificationItemWidget-content-actions > .mw-echo-ui-notificationItemWidget-content-actions-buttons.oo-ui-buttonSelectWidget > .oo-ui-buttonOptionWidget {
    min-width: 7em;
    max-width: 14em;
    overflow: hidden;
}

If I disable the max-width in dev tools, the full text appears.

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as Medium priority.Sep 15 2021, 6:48 PM
kostajh added a subscriber: kostajh.

User facing issue related to Growth feature under development, so I assume we want to fix this sooner rather than later.

That's interesting. I'm unable to reproduce (screenshot is from testwiki):

image.png (498×646 px, 38 KB)

I'm also unable to reproduce when I make my browser window smaller.

@LucasWerkmeister To trigger the notification, you need to use https://test.wikipedia.org/wiki/Special:ClaimMentee to claim someone to be your mentee. In this case, I needed some users with edits on testwiki from today, and your account met that criteria :-).

Firefox says the chosen font-family is DejaVu Sans, if that helps.

Funnily enough, when I log in a Firefox browser, the text does get cut off, albeit on a slightly different place:

image.png (451×910 px, 59 KB)

Tagging with Browser-Support-Firefox, as it appears to be FF-related.

Switching between legacy/modern vector does not change anything, but switching to https://test.wikipedia.org/wiki/Main_Page?useskin=timeless or https://test.wikipedia.org/wiki/Main_Page?useskin=monobook does.

@kostajh I think this is a bug in Notifications rather than in GrowthExperiments-Mentorship, as it works as expected in some environments. For that reason, I'll be unable to help here I'm afraid.