Page MenuHomePhabricator

Double layering ForeignAPIRepo's doesn't retrieve descriptions properly
Closed, ResolvedPublic

Description

Set up:

*Wiki 1 - $wgUseInstantCommons = true;
*Wiki 2 - Using ForeignApiRepo to get images from wiki 1.

Consider [[commons:Image:Example.svg]].

Wiki 1 displays the description page from commons like it should.

Wiki 2 displays:
This file is from a shared repository and may be used by other projects. The description on its file description page<link to commons> there is shown below.

There is currently no text in this page. You can search for this page title in other pages, search the related logs, or edit this page.


Expected behaviour is for Wiki 2 to display the description page from commons. At the very least it shouldn't display the no page exists text.

The quickest fix would probably be to do the same stuff we do for adding the foreign description page on action=view, on action=render. A more proper fix would probably be to fetch the description page directly from the right repository.


Version: 1.18.x
Severity: normal

Details

Reference
bz27111

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz27111.
bzimport added a subscriber: Unknown Object (MLST).
Bawolff created this task.Feb 2 2011, 6:36 PM

Does this also happen for people using en.wikipedia as file repository ?

Raising severity as this makes it harder for larger wiki (farm)s using commons as their repo to have their own repo as well.

Description pages on wiki 2 shouldn't show a page suggesting there is no description page.

(In reply to comment #1)

Does this also happen for people using en.wikipedia as file repository ?

yes. We just use ?action=render which gives stuff like: http://en.wikipedia.org/wiki/File:Example.svg?action=render

Easy fix I suppose is put the magically inserted text from the other repo into the ?action=render output. Would anything break doing that? (I personally can't think of anything)

dasch wrote:

This problem still exists in 1.20 and this is a big problem! because the license is not shown so I'm a bit concerned about the copyright legal things.

(In reply to comment #3)

This problem still exists in 1.20 and this is a big problem! because the
license is not shown so I'm a bit concerned about the copyright legal things.

1.20 Ain't done yet! ;) gerrit change 20660

patch merged.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM
Restricted Application added a project: Commons. · View Herald TranscriptJun 1 2018, 8:58 PM