Page MenuHomePhabricator
Create Task
Maniphest T291125

Make sure new access patterns of wb_changes table have proper indexes in place
Closed, ResolvedPublic
Actions

Description

With recent changes, we need to make sure we don't cause massive performance issues by doing unindexed queries.

Details

SubjectRepoBranchLines +/-
Add index on change_object_id in wb_changesmediawiki/extensions/Wikibasemaster+151 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Sep 15 2021, 7:17 PM
Addshore subscribed.Sep 16 2021, 8:21 AM
Michael moved this task from Backlog to ToDo on the Wikibase change dispatching scripts to jobs board.Sep 16 2021, 2:48 PM
gerritbot added a comment.Sep 17 2021, 7:45 PM

Change 721893 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Wikibase@master] Add index on change_object_id in wb_changes

https://gerrit.wikimedia.org/r/721893

gerritbot added a project: Patch-For-Review.Sep 17 2021, 7:45 PM
Ladsgroup claimed this task.Sep 17 2021, 8:03 PM
Ladsgroup moved this task from ToDo to Needs Review on the Wikibase change dispatching scripts to jobs board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 17 2021, 8:03 PM
gerritbot added a comment.Sep 22 2021, 12:08 PM

Change 721893 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add index on change_object_id in wb_changes

https://gerrit.wikimedia.org/r/721893

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 12:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 1:00 PM
Ladsgroup mentioned this in T291584: Schema change for adding change_object_id index on wb_changes.Sep 22 2021, 5:31 PM
Ladsgroup moved this task from Needs Review to Done on the Wikibase change dispatching scripts to jobs board.

Schema change filed: T291584: Schema change for adding change_object_id index on wb_changes

Michael closed this task as Resolved.Sep 28 2021, 2:52 PM

The schema change has been implemented, so I think that this task is done?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL