Page MenuHomePhabricator

Abort deploy-promote leaves the promote commit behind
Closed, DeclinedPublic

Description

This wednesday instead of promoting group1 I did:

deploy-promote all

I cancelled it when I found my mistake. The script did create a commit which promoted all wikis and since I have aborted the script the patch never got send to Gerrit.

I then did the proper command for group1

deploy-promote group1

Since the all commit has been left behind, the script:

  • hasn't crafted a new commit or rolledback the other wikis since group1 wikis were at the proper version.
  • it synced the erroneous commit promoting all wikis as a result

I don't have a good solution to catch that. Maybe when promoting we should ensure we don't also promote wikis from a future stage? Aka asking to promote group0 should ensure there are no other wikis and promoting to group1 should ensure we only have group0/group1 wikis.

Event Timeline

I don't think this is relevant anymore, we have scap train and spider pig nowadays.