Page MenuHomePhabricator
Create Task
Maniphest T291143

Apple Pay: Prevent flash of normal blue donate button before branded button appears
Closed, ResolvedPublic
Actions

Description

This flash is quite noticeable, and when the browser cache is disabled, I always see it, even without debug=true in the URL.

Details

SubjectRepoBranchLines +/-
Remove continue button from HTML where hiddenmediawiki/extensions/DonationInterfacemaster+34 -19
Customize query in gerrit

Event Timeline

AndyRussG created this task.Sep 16 2021, 4:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2021, 4:56 AM
• DStrine triaged this task as High priority.Sep 17 2021, 4:14 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
• DStrine added a project: fundraising sprint Roller Toaster.
XenoRyet added a project: fundraising sprint Screaming Goats Yelling Zoo.Sep 28 2021, 7:51 PM
AndyRussG moved this task from Backlog to Review on the fundraising sprint Screaming Goats Yelling Zoo board.Sep 30 2021, 3:34 PM
AndyRussG moved this task from Review to Backlog on the fundraising sprint Screaming Goats Yelling Zoo board.Oct 1 2021, 3:29 PM
XenoRyet added a project: Fundraising Sprint Technical debt house of horrors.Oct 12 2021, 8:18 PM
gerritbot added a comment.Oct 15 2021, 1:21 AM

Change 730957 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Remove continue button from HTML where hidden

https://gerrit.wikimedia.org/r/730957

gerritbot added a project: Patch-For-Review.Oct 15 2021, 1:21 AM
Ejegg subscribed.Oct 15 2021, 1:25 AM

With the latest merged stuff I was seeing the 'continue' button flash rather than the blue donate button. This patch should make that continue button go away.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Technical debt house of horrors board.Oct 15 2021, 1:59 AM
gerritbot added a comment.Oct 18 2021, 4:56 PM

Change 730957 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove continue button from HTML where hidden

https://gerrit.wikimedia.org/r/730957

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 5:11 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Technical debt house of horrors board.Oct 19 2021, 7:38 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Technical debt house of horrors board.Oct 20 2021, 1:39 AM
XenoRyet closed this task as Resolved.Oct 26 2021, 7:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL