Page MenuHomePhabricator

Make sure all crucial code paths in template dialog class(es) have tests
Closed, ResolvedPublic1 Estimated Story Points

Description

Subtask of T291062: Make sure all crucial template dialog features have tests.

For what we care about we can think of the two (sub)classes MWTransclusionDialog and MWTemplateDialog as a single dialog. The code is split because of a 3rd subclass in Cite.

  • onReplacePart
    • Remove template
    • Remove parameter
    • Closest part is selected after remove
    • Add template
    • Add parameter
    • Added part is selected
    • Unknown param input shows up in the correct circumstances
  • TBD...

Event Timeline

Change 721520 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] First QUnit test for dialog classes

https://gerrit.wikimedia.org/r/721520

awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-09-15 board.
awight added a subscriber: awight.
WMDE-Fisch changed the point value for this task from 8 to 1.
WMDE-Fisch added a subscriber: WMDE-Fisch.

During sprint planing: The first base of a integration qunittest should be merged. Apart from that we do not want to add to many new cases now.

Change 721520 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] First QUnit test for dialog classes

https://gerrit.wikimedia.org/r/721520