Page MenuHomePhabricator

Make sure all crucial code paths in BookletLayout pages have tests
Closed, ResolvedPublic5 Estimated Story Points

Description

Subtask of T291062: Make sure all crucial template dialog features have tests.

BookletLayout pages

  • Have a brief look at the MWAddParameterPage coverage. Anything missing you feel like should be covered?
  • The suggested value feature in MWParameterPage.createValueInput must be tested.
  • Test MWParameterPage.isSuggestedValueType with all possible types, allowed and disallowed. Note this is a private helper method. Coverage should probably be done via createValueInput.
  • Is it worth covering anything from the MWParameterPage constructor? It's huge! Probably not worth it, but have a look.
  • We struggled a bit with all the different messages MWTemplatePage can show. Is it worth covering this with tests?

Event Timeline

Change 724095 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Cover suggestedvalues feature in MWParameterPage class

https://gerrit.wikimedia.org/r/724095

Change 724095 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Cover suggestedvalues feature in MWParameterPage class

https://gerrit.wikimedia.org/r/724095

thiemowmde claimed this task.

Critical code-paths are covered. We typically don't cover widget constructors with unit but browser tests.