Page MenuHomePhabricator
Create Task
Maniphest T291241

Ensure changes to VE template dialog are working in VE citation dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We noticed that the MWTemplateDialog class is reused by the VE citation dialog and our changes to it should be reviewed and possibly adjusted for that context, as well as any other dependent context.

  • Make citation dialog work with the sidebar always open (aim to use most trivial fix). Note: Some of this code is implemented as a VE plugin in the Cite extension.
  • Investigate other dependencies (Signature Tool, anything else?) and what is reused there.

Discussed in story time.

Outcome

It was possible to carry over all new sidebar behaviors, while leaving the old workflow unchanged.

There are no other subclasses of either MWTemplateDialog or MWTransclusionDialog.

Details

SubjectRepoBranchLines +/-
Make function overridable by subclassesmediawiki/extensions/VisualEditormaster+1 -1
Make citation dialog behave more like VEmediawiki/extensions/Citemaster+15 -1
Fix Cite dialog failing with new sidebarmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lena_WMDE created this task.Sep 17 2021, 8:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2021, 8:43 AM
Lena_WMDE set the point value for this task to 3.Sep 17 2021, 8:43 AM
Lena_WMDE added a parent task: T286992: Deploy VE template dialog improvements to small set of wikis.
ECohen_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Sep 17 2021, 12:28 PM
awight claimed this task.Sep 17 2021, 1:31 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-15 board.
awight added a comment.Sep 17 2021, 1:45 PM

Dev notes: Setting up the service is annoying, I set up Citoid and its service, and the VE citation tool. Currently crashes after I click any of the citation types, seems we already have some incompatibilities:

Uncaught TypeError: dialog.bookletLayout.outlinePanel is undefined
    getSetupProcess http://.../extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js?04fb3:570
awight removed awight as the assignee of this task.Sep 17 2021, 1:46 PM
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-09-15 board.
awight subscribed.
gerritbot added a comment.Sep 17 2021, 2:19 PM

Change 721820 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix Cite dialog failing with new sidebar

https://gerrit.wikimedia.org/r/721820

gerritbot added a project: Patch-For-Review.Sep 17 2021, 2:19 PM
gerritbot added a comment.Sep 20 2021, 8:23 AM

Change 721820 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix Cite dialog failing with new sidebar

https://gerrit.wikimedia.org/r/721820

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 20 2021, 9:00 AM
gerritbot added a comment.Sep 20 2021, 9:03 AM

Change 722271 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Make citation dialog behave more like VE

https://gerrit.wikimedia.org/r/722271

awight added a comment.Sep 20 2021, 9:18 AM

With the above fix merged, we haven't damaged the old workflow:

image.png (445×506 px, 40 KB)

There's an opportunity to split the feature flag here, but I'll go ahead and put behind the VE configs (mainly $wgVisualEditorTransclusionDialogNewSidebar) for now. It's easy to add a new config later, if we're asked to selectively disable the Cite changes on some sites, and simplifies deployment and rollback.

Here's what the interface looks like with new sidebar changes applied,

image.png (910×913 px, 124 KB)

gerritbot added a comment.Sep 20 2021, 9:44 AM

Change 722274 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Make function overridable by subclasses

https://gerrit.wikimedia.org/r/722274

awight updated the task description. (Show Details)Sep 20 2021, 9:55 AM
awight moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-09-15 board.
WMDE-Fisch mentioned this in T284203: Deploy inline descriptions, extended sidebar and bigger dialog to small set of wikis.Sep 28 2021, 9:06 AM
gerritbot added a comment.Sep 28 2021, 9:14 AM

Change 722271 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Make citation dialog behave more like VE

https://gerrit.wikimedia.org/r/722271

awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 28 2021, 11:17 AM
gerritbot added a comment.Sep 28 2021, 2:10 PM

Change 722274 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make function overridable by subclasses

https://gerrit.wikimedia.org/r/722274

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2021, 2:10 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 28 2021, 4:00 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2021-09-29.Sep 29 2021, 8:07 AM
Lena_WMDE moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-09-29 board.Sep 29 2021, 8:08 AM
awight changed the point value for this task from 3 to 1.Sep 29 2021, 8:26 AM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 12 2021, 8:09 AM
WMDE-Fisch closed this task as Resolved.Oct 12 2021, 8:15 AM
WMDE-Fisch claimed this task.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-15 board.
Pols12 mentioned this in T293280: “Change reference type” button should still be displayed for template-based citations.Oct 13 2021, 5:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL