Page MenuHomePhabricator
Create Task
Maniphest T291244

Objects in ParserCache’s ExtensionData are not unserialized
Closed, ResolvedPublicBUG REPORT
Actions

Description

What happens?:

When I wrote the patch for SemanticMediaWiki to use JSON serialization instead of the PHP one in ParserCache as proposed by T263579, the patch for SemanticMediaWiki to use JSON serialization instead of the PHP one, the object is correctly serialized, but the unserialization has not effect: in the resulting ParserOutput object, the key $parserOutput->mExtensionData['smwdata'] is an array instead of an object.

It can be observed with a debugger (or a var_dump) by observing $parserOutput['smwdata'] in ParserOutput::newFromJsonArray() when Semantic MediaWiki is installed in the version of the PR.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

SubjectRepoBranchLines +/-
Unserialize objects in ParserCache->mExtensionData as objectsmediawiki/coreREL1_37+0 -1
Unserialize objects in ParserCache->mExtensionData as objectsmediawiki/coreREL1_36+0 -1
Unserialize objects in ParserCache->mExtensionData as objectsmediawiki/coremaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Seb35 created this task.Sep 17 2021, 9:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2021, 9:17 AM
Seb35 added a subscriber: • Pchelolo.Sep 17 2021, 9:17 AM

I tracked down the issue in I5785596d68/b956c77d2 by @Pchelolo, and it seems there is an issue in ParserOutput since the same variable is overriden:

$this->mExtensionData = $unserializer->unserializeArray( $jsonData['ExtensionData'] ?? [] );
$this->mExtensionData = $jsonData['ExtensionData'];

The correct version is probably to remove the second line: it correctly unserializes objects as objects.

Seb35 added a parent task: T263579: Change ParserCache serialization format to JSON.Sep 17 2021, 9:19 AM
Seb35 renamed this task from Objects in ExtensionData’s ParserCache are not unserialized to Objects in ParserCache’s ExtensionData are not unserialized.Sep 17 2021, 9:31 AM
gerritbot added a comment.Sep 17 2021, 9:39 AM

Change 721772 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/core@master] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721772

gerritbot added a project: Patch-For-Review.Sep 17 2021, 9:39 AM
gerritbot added a comment.Sep 17 2021, 3:12 PM

Change 721772 merged by jenkins-bot:

[mediawiki/core@master] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721772

gerritbot added a comment.Sep 17 2021, 3:41 PM

Change 721832 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/core@REL1_36] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721832

gerritbot added a comment.Sep 17 2021, 3:41 PM

Change 721833 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/core@REL1_37] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721833

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 17 2021, 4:00 PM
gerritbot added a comment.Sep 17 2021, 6:33 PM

Change 721832 merged by jenkins-bot:

[mediawiki/core@REL1_36] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721832

gerritbot added a comment.Sep 17 2021, 6:34 PM

Change 721833 merged by jenkins-bot:

[mediawiki/core@REL1_37] Unserialize objects in ParserCache->mExtensionData as objects

https://gerrit.wikimedia.org/r/721833

ReleaseTaggerBot added projects: MW-1.37-notes, MW-1.36-notes.Sep 17 2021, 7:00 PM
Seb35 closed this task as Resolved.Sep 20 2021, 1:31 PM
Seb35 claimed this task.
Dylsss changed the task status from Duplicate to Resolved.Apr 10 2022, 3:01 AM
Dylsss closed this task as a duplicate of T289448: Double assignment to ParserOutput->mExtensionData.
Dylsss merged a task: T289448: Double assignment to ParserOutput->mExtensionData.
Dylsss added subscribers: CtrlZvi, Dylsss.
Dylsss removed a project: Patch-For-Review.Apr 10 2022, 3:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL