Page MenuHomePhabricator

Regression in link styles on Content Translation
Closed, ResolvedPublic

Description

Currently links in Content translation are affected by a regression in their styling. They are now displayed with a different blue and showing an underline.

The expected style would be to use the Accent50 blue (#36C) and use no underline.

Below you can see a screenshot from a past ticket and a recent one side by side:

Original link style (as intended)Current link style (regression)
link-color-original.png (629×1 px, 432 KB)
link-color-current.png (599×1 px, 248 KB)

Although screenshots show the translation editor, the regression also affects the dashboard (e.g., when showing search results)

Event Timeline

Regression from the fix for T289570: Special:ContentTranslation: The use of the `legacy` feature with ResourceLoaderSkinModule is deprecated.
But link color with 36c is not part of mediawiki core styles. It is mentioned in design guidelines, but not implemented. CX can use 36c since we have custom skin.

Change 722130 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX Skin: Inlclude link related styles and overrides

https://gerrit.wikimedia.org/r/722130

Change 722130 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Skin: Inlclude link related styles and overrides

https://gerrit.wikimedia.org/r/722130

Etonkovidova added a subscriber: Etonkovidova.

Checked on wmf.9 - the fix is in place:

Screen Shot 2021-11-28 at 6.49.49 PM.png (1×2 px, 490 KB)

@Pginer-WMF - the underline is present for the following (see the screenshots below). Is it expected?

Screen Shot 2021-11-28 at 6.35.02 PM.png (574×1 px, 94 KB)
Screen Shot 2021-11-28 at 6.51.20 PM.png (644×962 px, 51 KB)

@Pginer-WMF - the underline is present for the following (see the screenshots below). Is it expected?

No. The underline in buttons is not expected. It is not part of the states for buttons in the Style guide.

@Pginer-WMF - the underline is present for the following (see the screenshots below). Is it expected?

No. The underline in buttons is not expected. It is not part of the states for buttons in the Style guide.

Thx, @Pginer-WMF! I filed T297532 (as a minor issue).

This task is Resolved.