Page MenuHomePhabricator

Uncomment movefile right in default settings
Closed, ResolvedPublic

Description

It's been tested and such, we should probably get around to un-commenting it one day.


Version: unspecified
Severity: enhancement
URL: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/DefaultSettings.php?view=markup#l3228
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=38186

Details

Reference
bz27132

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:24 PM
bzimport set Reference to bz27132.
bzimport added a subscriber: Unknown Object (MLST).

CC'ing Bryan/TheDJ

Either of you guys know how stable this is in core/1.17?

And hence, whether you feel we should do this and backport to 1.17?

Bryan.TongMinh wrote:

It has been widely used on Commons, but only by sysops. I am not up-to-date on its status and bugs though.

It has been pretty stable. I believe there is still one issue though. I seem to remember there is not a proper rollback of the actions if one of the move's actions fails. This has happened a few times this year (mostly due to filesystem problems ???), resulting in part of the file record being move (thumbs separated from originals, originals separated from page record). I believe some improvements were made in this area, but i'm not sure we solved them all. Haven't heard about such a thing in a couple of months though.

Bryan.TongMinh wrote:

I've looked into this a bit, and while it is ok, I would like to implement better error handling (similar to file restore: copy-verify-dbupdate-cleanup). Can we hold this off until 1.18?

Bryan gave us his blessing to do this in triage. r93871