Page MenuHomePhabricator
Create Task
Maniphest T291327

Assign backup mentors to users
Closed, ResolvedPublic
Actions

Description

The T280307: Mentor dashboard: M2 mentor tools/settings part of the mentor dashboard will allow mentors to set themselves as away. This will result in questions asked by their mentees being sent to a backup mentor for the duration of their away-ness. This means we need to assign backup mentors to the users as well.

Thanks to mentor/mentee relationship now being stored in a DB table, which has column to indicate mentor's role, this should be just a matter of changing the mentor manager and relevant hooks to account for different kind of mentors.

Plan
  1. Require all callers of MentorStore::loadMentorUser() and MentorStore::setMentorForUser() to pass a valid mentor role. This will make the code more understandable. Currently, the default is to use ROLE_PRIMARY.
  2. Add backup mentor logic to the MentorManager
  3. Assign backup mentors to new users from MentorHooks

We do not need to care about existing users, as MentorManager will assign a backup mentor to them on-the-fly.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
For away mentors, direct their questions to a backup mentormediawiki/extensions/GrowthExperimentsmaster+61 -16
MentorManager: Add logic for backup mentormediawiki/extensions/GrowthExperimentsmaster+307 -41
Explicitly pass role to callers of MentorStore's set/get functionsmediawiki/extensions/GrowthExperimentsmaster+44 -27
Mentee overview: Only include mentor's primary menteesmediawiki/extensions/GrowthExperimentsmaster+1 -1
MentorStore: Deprecate calling loadMentorUser/setMentorForUser with no rolemediawiki/extensions/GrowthExperimentsmaster+18 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Sep 18 2021, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2021, 1:38 PM
Urbanecm_WMF triaged this task as Low priority.Sep 18 2021, 1:39 PM
Urbanecm_WMF added a subtask: T291188: Drop PreferenceMentorStore.
gerritbot added a comment.Sep 18 2021, 1:42 PM

Change 721981 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Deprecate calling loadMentorUser/setMentorForUser with no role

https://gerrit.wikimedia.org/r/721981

gerritbot added a project: Patch-For-Review.Sep 18 2021, 1:42 PM
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 18 2021, 1:44 PM
gerritbot added a comment.Sep 18 2021, 2:07 PM

Change 721982 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Explicitly pass mentor role to callers of MentorStore's set/get functions

https://gerrit.wikimedia.org/r/721982

gerritbot added a comment.Sep 18 2021, 2:16 PM

Change 721981 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Deprecate calling loadMentorUser/setMentorForUser with no role

Reason:

merged into 721982

https://gerrit.wikimedia.org/r/721981

gerritbot added a comment.Sep 18 2021, 2:22 PM

Change 721983 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Only include mentor's primary mentees

https://gerrit.wikimedia.org/r/721983

gerritbot added a comment.Sep 18 2021, 2:48 PM

Change 721985 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorManager: Add logic for backup mentor

https://gerrit.wikimedia.org/r/721985

Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.Sep 18 2021, 4:44 PM
gerritbot added a comment.Sep 21 2021, 1:21 AM

Change 721983 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Only include mentor's primary mentees

https://gerrit.wikimedia.org/r/721983

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 21 2021, 4:00 PM
gerritbot added a comment.Sep 22 2021, 7:45 AM

Change 721982 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Explicitly pass role to callers of MentorStore's set/get functions

https://gerrit.wikimedia.org/r/721982

gerritbot added a comment.Sep 22 2021, 1:06 PM

Change 722862 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WIP: For away mentors, direct questions to a replacement one

https://gerrit.wikimedia.org/r/722862

Urbanecm_WMF closed subtask T291188: Drop PreferenceMentorStore as Resolved.Oct 15 2021, 6:36 AM
gerritbot added a comment.Oct 26 2021, 5:30 AM

Change 721985 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorManager: Add logic for backup mentor

https://gerrit.wikimedia.org/r/721985

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.7; 2021-11-02); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Oct 26 2021, 6:00 AM
gerritbot added a comment.Oct 27 2021, 3:37 AM

Change 722862 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] For away mentors, direct their questions to a backup mentor

https://gerrit.wikimedia.org/r/722862

Urbanecm_WMF added a comment.Nov 5 2021, 6:59 PM

Backup mentors are now a thing:

mysql:research@dbstore1005.eqiad.wmnet [enwiki]> select gemm_mentor_role, count(*) from growthexperiments_mentor_mentee group by gemm_mentor_role;
+------------------+----------+
| gemm_mentor_role | count(*) |
+------------------+----------+
| backup           |     3265 |
| primary          |   641180 |
+------------------+----------+
2 rows in set (0.348 sec)

mysql:research@dbstore1005.eqiad.wmnet [enwiki]> use cswiki;
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Database changed
mysql:research@dbstore1005.eqiad.wmnet [cswiki]> select gemm_mentor_role, count(*) from growthexperiments_mentor_mentee group by gemm_mentor_role;
+------------------+----------+
| gemm_mentor_role | count(*) |
+------------------+----------+
| backup           |       53 |
| primary          |    33003 |
+------------------+----------+
2 rows in set (0.029 sec)

I also ensured a backup mentor relationship gets assigned when the primary one is set to away.

Urbanecm_WMF closed this task as Resolved.Nov 5 2021, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits