Page MenuHomePhabricator

Flow's Exporter class extends WikiExporter and needs to have it's constructor arguments updated
Closed, ResolvedPublic

Description

In rMW2fbf13812ad8: WikiExporter: inject services services were injected into WikiExporter. Flow' Exporter class extends WikiExporter and thus needs it's constructor arguments updated.

Phan is currently also failing:

18:43:27 includes/Dump/Exporter.php:89 PhanParamTooFew Call with 3 arg(s) to \WikiExporter::__construct(\Wikimedia\Rdbms\IDatabase $db, \MediaWiki\HookContainer\HookContainer $hookContainer, \MediaWiki\Revision\RevisionStore $revisionStore, \TitleParser $titleParser, array|int $history = self::CURRENT, int $text = self::TEXT, ?array $limitNamespaces = null) which requires 4 arg(s) defined at ../../includes/export/WikiExporter.php:116

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Zabe triaged this task as High priority.Sep 19 2021, 9:13 AM

Change 722062 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Update constructor arguments of Exporter to match WikiExporter

https://gerrit.wikimedia.org/r/722062

Change 722062 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Update constructor arguments of Exporter to match WikiExporter

https://gerrit.wikimedia.org/r/722062

Zabe claimed this task.