Page MenuHomePhabricator

Remove global function mimeTypeMatch()
Closed, ResolvedPublic

Description

The global function mimeTypeMatch() is completly unused, see codesearch: https://codesearch.wmcloud.org/search/?q=mimeTypeMatch&i=nope&files=&excludeFiles=&repos=. It also doesn't fit our Coding conventions, see https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Functions.

I would propose that it can be removed as it does no longer seem to be necessary. The only usage was removed with rMW269e7e1d4480: Drop global function wfNegotiateType, deprecated in 1.36.

Event Timeline

Change 722064 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Rename global function mimeTypeMatch() to wfMimeTypeMatch()

https://gerrit.wikimedia.org/r/722064

Zabe renamed this task from Rename mimeTypeMatch() to wfMimeTypeMatch() to Remove global function mimeTypeMatch().Sep 19 2021, 3:04 PM
Zabe updated the task description. (Show Details)

Change 722064 merged by jenkins-bot:

[mediawiki/core@master] Remove global function mimeTypeMatch()

https://gerrit.wikimedia.org/r/722064

Zabe claimed this task.