Page MenuHomePhabricator
Create Task
Maniphest T291392

Refactor the URI.query
Closed, ResolvedPublic
Actions

Description

Ticket Scope
We have refactored the underlying code that takes care of updating the "url" when the users navigates and utilize medaiWiki.

Information for QA:

  • Anything that triggers an URL change should be tested
  • Forward and Backward navigation
  • Filter selection
  • Tab selection
  • New search

Details

SubjectRepoBranchLines +/-
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+6 -6
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.5+6 -6
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.5+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchmaster+6 -6
Refactor the URI.querymediawiki/extensions/MediaSearchmaster+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchmaster+675 -178
Customize query in gerrit

Related Objects
Search...

Event Timeline

SimoneThisDot created this task.Sep 20 2021, 2:29 PM
SimoneThisDot moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Sep 20 2021, 2:33 PM

Change 722374 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/722374

gerritbot added a project: Patch-For-Review.Sep 20 2021, 2:33 PM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 23 2021, 11:48 AM
gerritbot added a comment.Oct 5 2021, 9:40 PM

Change 722374 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/722374

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2021, 10:10 PM
SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 6 2021, 12:26 PM
SimoneThisDot updated the task description. (Show Details)Oct 6 2021, 12:28 PM
SimoneThisDot mentioned this in T292221: Cannot read property 'disabled' of undefined / Cannot read properties of undefined (reading 'disabled') .Oct 6 2021, 12:44 PM
SimoneThisDot merged a task: T292221: Cannot read property 'disabled' of undefined / Cannot read properties of undefined (reading 'disabled') .Oct 6 2021, 1:46 PM
SimoneThisDot added subscribers: Jdlrobson, Masumrezarock100.
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 7 2021, 12:18 AM
Etonkovidova subscribed.

Checked in commons on betalabs - looks as it works as expected. Moving to Verify on Production.

Seddon subscribed.EditedOct 12 2021, 12:00 PM

Issue: Go to Special:MediaSearch on with no search term. Enter term and either click search or hit enter. The string would be added to the url but no search would occur. This was repeatable and not present in changes prior to this one, and present in all changes since.

Confirmed on 2 instances on windows with Chrome and Firefox, Mac with Chrome and beta cluster (now since rolled back)

gerritbot added a comment.Oct 12 2021, 2:04 PM

Change 730208 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a project: Patch-For-Review.Oct 12 2021, 2:04 PM
SimoneThisDot moved this task from Verify on Production to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 13 2021, 12:15 PM
Jdlrobson triaged this task as High priority.EditedOct 18 2021, 6:15 PM
Jdlrobson added a project: Wikimedia-production-error.

The volume of errors from this bug is quite high -4481 from last 24 hrs.

Newly introduced bugs that show up on the mw-client-errors dashboard or mw-client-error editing dashboard at a rate of over 1000 errors in a 12 hr period are currently judged as train blockers [1] so this fix should be deployed sometime this week (next week at latest - see T281169#7437764).

[1] https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train

Jdlrobson added a parent task: T281169: 1.38.0-wmf.5 deployment blockers.Oct 18 2021, 6:16 PM
Jdlrobson mentioned this in T281169: 1.38.0-wmf.5 deployment blockers.Oct 18 2021, 6:21 PM
Seddon added a comment.Oct 18 2021, 6:27 PM

A patch is incoming that should hopefully solve this.

hashar subscribed.Oct 18 2021, 9:33 PM

The branch is being cut on Tuesday at 2am UTC. I will deploy to group 0 on Tuesday around 13:00 UTC.

If the patch in master is reviewed and merged before the cut, it will be in 1.38.0-wmf.5, else it will need a cherry-pick.

If it is serious enough, please consider backporting it to 1.38.0-wmf.4 and deploying to production (release engineering can assist as well as people attending the backport deployment window)

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.Oct 18 2021, 11:45 PM
Jdforrester-WMF subscribed.

Train blocker -> UBN! status.

Jdforrester-WMF added a comment.Oct 18 2021, 11:48 PM

Sorry, I'm a bit muddled here the reference patch was reverted in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/729919 six days ago. The re-application hasn't landed yet. Is the problem the code that was reverted (in which case, presumably this is fixed?) or the lack of this code having landed yet (in which case, is there a different patch that also needs reverting?)?

Seddon added a comment.Oct 19 2021, 2:17 AM

Last weeks reverted parch that was originally going out last week got reverted because of a more widespread user facing error. That was fixed but along with this the same patch is expected to fix these production errors and should now be ready at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/730208.

The issue only affects commons so there should be no issue in deploying to Group0 tomorrow. I will try and get this merged and backported Tuesday UTC to wmf.4 and wmf.5

Seddon lowered the priority of this task from Unbreak Now! to High.Oct 19 2021, 2:25 AM

Based on:

  • @hashar proceeding with train;
  • that the specific issue has been present for nearly a month;
  • that a patch is now ready and should be merged and backported Tuesday 19.

I'm bumping this back down to high.

Seddon added a subtask: T292221: Cannot read property 'disabled' of undefined / Cannot read properties of undefined (reading 'disabled') .Oct 19 2021, 2:34 AM
gerritbot added a comment.Oct 19 2021, 10:43 AM

Change 730208 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 11:10 AM
gerritbot added a comment.Oct 19 2021, 12:30 PM

Change 731940 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/731940

gerritbot added a project: Patch-For-Review.Oct 19 2021, 12:30 PM
gerritbot added a comment.Oct 19 2021, 1:27 PM

Change 731940 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/731940

SimoneThisDot mentioned this in T293335: Cannot convert undefined or null to object when trying to restorePageState.Oct 19 2021, 1:56 PM
SimoneThisDot merged a task: T293335: Cannot convert undefined or null to object when trying to restorePageState.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 19 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 2:11 PM
gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731961 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a project: Patch-For-Review.Oct 19 2021, 6:08 PM

Change 731962 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

gerritbot added a comment.Oct 19 2021, 6:10 PM

Change 732026 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/732026

gerritbot added a comment.Oct 19 2021, 6:11 PM

Change 732027 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/732027

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731961 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731962 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 732026 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/732026

gerritbot added a comment.Oct 19 2021, 6:38 PM

Change 732027 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/732027

Stashbot mentioned this in T291622: [M] CheckForMore always return true.Oct 19 2021, 6:45 PM
Stashbot mentioned this in T293554: Switching tabs in MediaSearch does not re-query the search.

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:45:27Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/: 694580a: c02e301: MediaSearch backports(T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Stashbot added a comment.Oct 19 2021, 6:46 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:46:30Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/MediaSearch/: a84a675: 3231578: MediaSearch backports (T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Jdlrobson awarded a token.Oct 19 2021, 6:54 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 19 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 7:10 PM
Seddon moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 20 2021, 4:20 AM
Etonkovidova closed this task as Resolved.Oct 21 2021, 12:23 AM

Checked on commons wmf.5 - all seem to work as expected.

Krinkle moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Mar 14 2022, 4:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL