Page MenuHomePhabricator

Do not automatically add a signature if post-transclusion wikitext ends with one
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Create a template (any page) that ends with ~~<noinclude/>~~
  • Substitute the template in a new DiscussionTools section, or in a DiscussionTools reply
  • Submit

What happens?:

  • The message ends with two identical signatures

What should have happened instead?:

  • The message ends with one single signature that was provided by the template

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

  • current enwiki

Event Timeline

Change 759841 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

https://gerrit.wikimedia.org/r/759841

Change 759841 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

https://gerrit.wikimedia.org/r/759841

Signature is not duplicated as expected.