Page MenuHomePhabricator

RuntimeException: iconClass before type is no longer supported.
Closed, ResolvedPublicBUG REPORT

Description

https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=minerva is throwing a fatal exception.
This is related to the changes in T288678 (specifically https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/720067).
The method changed was not marked as @stable and I forgot to check any instances in codesearch.

What should have happened instead?:

No fatal exception in this case.

  • I will patch GrowthExperiments to use the preferred function call.
  • We should mark the class as @stable with a note that it's used by other extensions to avoid this happening again.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

QA

Enable newcomer home page on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-personal
Confirm https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=minerva doesn't throw an exception

QA Results - Beta

ACStatusDetails
1T291423#7374795

Event Timeline

Jdlrobson triaged this task as Unbreak Now! priority.
Jdlrobson added a project: Regression.

Change 722421 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Allow overriding of icon

https://gerrit.wikimedia.org/r/722421

Change 722422 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Override icon

https://gerrit.wikimedia.org/r/722422

Change 722421 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Allow overriding of icon

https://gerrit.wikimedia.org/r/722421

Change 722422 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Override icon

https://gerrit.wikimedia.org/r/722422

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Sep 20 2021, 9:14 PM

Fatal has been addressed. I want to collect some thoughts around supporting the use case for this extension a bit more before closing.

Change 722729 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Update menu items via hook

https://gerrit.wikimedia.org/r/722729

Change 722730 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Begin using core menu definitions for sourcing menu data

https://gerrit.wikimedia.org/r/722730

For code review I'm looking for someone to read through T291568 and tell me it makes sense as a general direction.

bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Enable newcomer home page on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-personal
✅ AC1: Confirm https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=minerva doesn't throw an exception

Screen Shot 2021-09-23 at 9.44.10 AM.png (999×995 px, 203 KB)

Change 722730 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Begin using core menu definitions for sourcing menu data

Reason:

My thinking is that we should provide a generic solution in core inspired by Minerva's menu code, and then later plan to use that in Minerva https://gerrit.wikimedia.org/r/c/mediawiki/core/+/726995

https://gerrit.wikimedia.org/r/722730