Page MenuHomePhabricator
Create Task
Maniphest T291507

Make it possible to turn off post-payments monthly convert by URL parameter
Closed, ResolvedPublic
Actions

Description

Currently we can turn on post-payments monthly convert for a given donation with the variant parameter

However as far as I can tell if a country is in $wgDonationInterfaceMonthlyConvertCountries, it's possible to switch to a different variant, but not to completely disable post-payments monthly convert.

Being able to turn this off via a URL parameter would be helpful for testing, and avoid us having to pester fr-tech for config changes (e.g. T291429). It could also help responsiveness if there's some urgent issue with monthly convert and no one from fr-tech is available.

Details

SubjectRepoBranchLines +/-
Allow to turn off monthly convert with variant parametermediawiki/extensions/DonationInterfacemaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Pcoombe created this task.Sep 21 2021, 5:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2021, 5:14 PM
Ejegg subscribed.Sep 21 2021, 5:23 PM

For now, how about we just turn it off via the countries parameter and send the variant for when you want to turn it on?

gerritbot added a comment.Sep 21 2021, 5:24 PM

Change 722662 had a related patch set uploaded (by Pcoombe; author: Pcoombe):

[mediawiki/extensions/DonationInterface@master] Allow to turn off monthly convert with variant parameter

https://gerrit.wikimedia.org/r/722662

gerritbot added a project: Patch-For-Review.Sep 21 2021, 5:24 PM
Pcoombe added a comment.Sep 21 2021, 5:28 PM

@Ejegg I suppose that could work too, but we would need to make a bunch of changes to the default behaviour in banners and donatewiki

• DStrine moved this task from Triage to Parking lot (post Q2) on the Fundraising-Backlog board.Sep 27 2021, 4:52 PM
• DStrine moved this task from Parking lot (post Q2) to Sprint +1 on the Fundraising-Backlog board.Sep 27 2021, 7:51 PM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Sep 28 2021, 7:49 PM
XenoRyet added a project: fundraising sprint Screaming Goats Yelling Zoo.Sep 28 2021, 7:51 PM
gerritbot added a comment.Oct 4 2021, 2:59 AM

Change 722662 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Allow to turn off monthly convert with variant parameter

https://gerrit.wikimedia.org/r/722662

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 4 2021, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 3:10 AM
Pcoombe added a comment.Oct 8 2021, 5:22 PM

Just tested this with variant=noMonthlyConvert and confirmed it works! Thanks!

Ejegg moved this task from Backlog to Done on the fundraising sprint Screaming Goats Yelling Zoo board.Oct 12 2021, 7:12 PM
XenoRyet closed this task as Resolved.Oct 12 2021, 7:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL