Page MenuHomePhabricator

Make it possible to turn off post-payments monthly convert by URL parameter
Closed, ResolvedPublic


Currently we can turn on post-payments monthly convert for a given donation with the variant parameter

However as far as I can tell if a country is in $wgDonationInterfaceMonthlyConvertCountries, it's possible to switch to a different variant, but not to completely disable post-payments monthly convert.

Being able to turn this off via a URL parameter would be helpful for testing, and avoid us having to pester fr-tech for config changes (e.g. T291429). It could also help responsiveness if there's some urgent issue with monthly convert and no one from fr-tech is available.

Event Timeline

For now, how about we just turn it off via the countries parameter and send the variant for when you want to turn it on?

Change 722662 had a related patch set uploaded (by Pcoombe; author: Pcoombe):

[mediawiki/extensions/DonationInterface@master] Allow to turn off monthly convert with variant parameter

@Ejegg I suppose that could work too, but we would need to make a bunch of changes to the default behaviour in banners and donatewiki

Change 722662 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Allow to turn off monthly convert with variant parameter

Just tested this with variant=noMonthlyConvert and confirmed it works! Thanks!