Page MenuHomePhabricator

[betalabs]Post-edit dialog: mw-ge-small-task-card-metadata-container attempts to load pageviews info
Closed, ResolvedPublic

Description

The issue seems to be specific to betalabs (testwiki wmf.1 seems to be fine).

  1. On a betalabs - go from Special:Homepage to one of SE articles.
  2. Make some edits on SE article and publish.

The post-edit dialog shows a placeholder for pageview info:

Screen Shot 2021-09-21 at 11.33.24 AM.png (864×1 px, 134 KB)

Note: On current production (wmf.23/wmf.1) - the pageview placeholder is not shown:

Screen Shot 2021-09-20 at 3.38.35 PM.png (904×1 px, 164 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

When task.pageviews is undefined, the skeleton class is added as this can indicate that the page view is being lazy loaded. When task.pageviews is null, the page view is not shown. The current mechanism to hide the page view sets the value to undefined when there is a page view value, so this works on testwiki (and local environment) since the page view endpoint returns 404., but not in betalabs which does have pageviews.

Change 722700 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Post-edit Panel: Set task.pageviews to null rather than undefined

https://gerrit.wikimedia.org/r/722700

Tested by mocking pageviews value locally:

Before fix:

Screen Shot 2021-09-21 at 4.15.16 PM.png (836×1 px, 243 KB)

After fix:

Screen Shot 2021-09-21 at 4.09.25 PM.png (840×1 px, 182 KB)

Change 722700 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post-edit Panel: Set task.pageviews to null rather than undefined

https://gerrit.wikimedia.org/r/722700

Change 722932 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.1] Post-edit Panel: Set task.pageviews to null rather than undefined

https://gerrit.wikimedia.org/r/722932

Change 722932 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.1] Post-edit Panel: Set task.pageviews to null rather than undefined

https://gerrit.wikimedia.org/r/722932

Mentioned in SAL (#wikimedia-operations) [2021-09-22T18:32:09Z] <legoktm@deploy1002> Synchronized php-1.38.0-wmf.1/extensions/GrowthExperiments/modules/help/ext.growthExperiments.PostEditPanel.js: Post-edit Panel: Set task.pageviews to null rather than undefined (T291510) (duration: 01m 05s)

Checked in betalabs - the issue is not present; checked in testwiki wmf.1 - works as expected (no regression).