PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.38.0-wmf.1
reqId: d4858f36-138c-48ed-893c-beb1c32ee600
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute]

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.1/extensions/CentralAuth/includes/Special/SpecialCentralLogin.php(77)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.1/includes/debug/MWDebug.php(375): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.1/includes/debug/MWDebug.php(351): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.1/includes/GlobalFunctions.php(1030): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.1/includes/StubGlobalUser.php(145): wfDeprecatedMsg(string, string, boolean, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.1/extensions/CentralAuth/includes/Special/SpecialCentralLogin.php(294): StubGlobalUser->__destruct()
#6 /srv/mediawiki/php-1.38.0-wmf.1/extensions/CentralAuth/includes/Special/SpecialCentralLogin.php(77): MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin->doLoginComplete(string)
#7 /srv/mediawiki/php-1.38.0-wmf.1/includes/specialpage/SpecialPage.php(647): MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin->execute(string)
#8 /srv/mediawiki/php-1.38.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1367): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#10 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(925): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(559): MediaWiki->main()
#12 /srv/mediawiki/php-1.38.0-wmf.1/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.38.0-wmf.1/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Impact

One instance of the error was spotted within minutes of 1.38.0-wmf.1 group0 promotion.

Notes

Possibly related to risky patch noted in T281165#7362605.

Details

Request URL: https://www.mediawiki.org/wiki/Special:CentralLogin/complete?token=*

Subject	Repo	Branch	Lines +/-
Avoid $wgUser deprecation warnings	mediawiki/extensions/CentralAuth	wmf/1.38.0-wmf.1	+12 -5
Avoid $wgUser deprecation warnings	mediawiki/extensions/CentralAuth	master	+12 -5
Avoid $wgUser deprecation warnings	mediawiki/extensions/CentralAuth	REL1_37	+12 -5

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T11968 Reduce use of global and public variables
Open		None	T159283 Deprecate non-configuration globals
Open		DannyS712	T159299 Deprecate and remove $wgUser
Resolved		DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved		DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Stalled		DannyS712	T242994 CentralAuth needs uses of global $wgUser removed
Resolved	Release	dduvall	T281165 1.38.0-wmf.1 deployment blockers
Resolved	PRODUCTION ERROR	DannyS712	T291515 PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute]

Event Timeline

dduvall created this task.Sep 21 2021, 7:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2021, 7:14 PM

dduvall added a subtask: T281165: 1.38.0-wmf.1 deployment blockers.Sep 21 2021, 7:15 PM

• Pchelolo added a subscriber: DannyS712.Sep 21 2021, 7:15 PM

dduvall removed a subtask: T281165: 1.38.0-wmf.1 deployment blockers.Sep 21 2021, 7:20 PM

dduvall added a parent task: T281165: 1.38.0-wmf.1 deployment blockers.

Zabe subscribed.Sep 21 2021, 7:21 PM

Deprecation === not a UBN, but still fairly high since we want to emit these deprecations in 1.37.

Not surprising we got some. This specific deprecation is interesting - if it was in core, we'd use StubGlobalUser::setUser here, but we want it to be @internal. Maybe we still can?

Zabe added a project: MediaWiki-extensions-CentralAuth.Sep 21 2021, 7:42 PM

Zabe moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Sep 21 2021, 8:35 PM

In T291515#7370010, @Pchelolo wrote:

Deprecation === not a UBN, but still fairly high since we want to emit these deprecations in 1.37.

Not surprising we got some. This specific deprecation is interesting - if it was in core, we'd use StubGlobalUser::setUser here, but we want it to be @internal. Maybe we still can?

I forget - the reason I was planning to have StubGlobalUser::setUser() be available to extensions was in part because CentralAuth wants to change $wgUser and not change it back - lets use StubGlobalUser::setUser() for now, in a few weeks we'll be dropping $wgUser entirely so its just for a little bit. The fix should be backported to 1.37

Change 722464 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CentralAuth@master] Use StubGlobalUser::setUser() to bypass deprecation warnings

https://gerrit.wikimedia.org/r/722464

gerritbot added a project: Patch-For-Review.Sep 21 2021, 8:38 PM

DannyS712 changed the task status from Open to In Progress.Sep 21 2021, 8:42 PM

DannyS712 claimed this task.

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 21 2021, 8:42 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Sep 21 2021, 8:42 PM

Change 722713 had a related patch set uploaded (by Majavah; author: DannyS712):

[mediawiki/extensions/CentralAuth@REL1_37] Avoid $wgUser deprecation warnings

https://gerrit.wikimedia.org/r/722713

Change 722464 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Avoid $wgUser deprecation warnings

https://gerrit.wikimedia.org/r/722464

Change 722713 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@REL1_37] Avoid $wgUser deprecation warnings

https://gerrit.wikimedia.org/r/722713

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 7:10 AM

Change 722896 had a related patch set uploaded (by Dduvall; author: DannyS712):

[mediawiki/extensions/CentralAuth@wmf/1.38.0-wmf.1] Avoid $wgUser deprecation warnings

https://gerrit.wikimedia.org/r/722896

gerritbot added a project: Patch-For-Review.Sep 22 2021, 3:46 PM

DannyS712 added a parent task: T242994: CentralAuth needs uses of global $wgUser removed.Sep 22 2021, 3:48 PM

Change 722896 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.38.0-wmf.1] Avoid $wgUser deprecation warnings

https://gerrit.wikimedia.org/r/722896

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 7:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-22T19:11:00Z] <dduvall@deploy1002> Synchronized php-1.38.0-wmf.1/extensions/CentralAuth: Backport: [[gerrit:722896|Avoid $wgUser deprecation warnings (T291515)]] (duration: 01m 06s)

In T291515#7370360, @DannyS712 wrote:

in a few weeks we'll be dropping $wgUser entirely so its just for a little bit. The fix should be backported to 1.37

I've backported/deployed the patch for 1.38.0-wmf.1 and haven't seen any deprecation warnings since. Can we close this task or would you like to retain it (move it to next week's train) to track the removal of the workaround?

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.1; 2021-09-21); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 8:00 PM

dduvall edited parent tasks, added: T281166: 1.38.0-wmf.2 deployment blockers; removed: T281165: 1.38.0-wmf.1 deployment blockers.Sep 23 2021, 10:44 PM

In T291515#7372968, @dduvall wrote:

In T291515#7370360, @DannyS712 wrote:

in a few weeks we'll be dropping $wgUser entirely so its just for a little bit. The fix should be backported to 1.37

I've backported/deployed the patch for 1.38.0-wmf.1 and haven't seen any deprecation warnings since. Can we close this task or would you like to retain it (move it to next week's train) to track the removal of the workaround?

No need to keep open, removals will be done separately later - its not going to be removed this week. I'm planning on waiting to remove $wgUser until after 1.37 is fully released.

Thanks! I'll move it back to 1.38.0-wmf.1 for posterity.

dduvall edited parent tasks, added: T281165: 1.38.0-wmf.1 deployment blockers; removed: T281166: 1.38.0-wmf.2 deployment blockers.Sep 23 2021, 11:54 PM

PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute]Closed, ResolvedPublicPRODUCTION ERRORActions